Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 323723002: Removing WTL from content runner. (Closed)

Created:
6 years, 6 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Removing WTL from content runner. The _Module object is used by ATL COM classes to lock the module, like so _pAtlModule->Lock(); For example when CreateInstance is called: BrowserAccessibility* BrowserAccessibility::Create() { CComObject<BrowserAccessibilityWin>* instance; HRESULT hr = CComObject<BrowserAccessibilityWin>::CreateInstance(&instance); We need to get rid of WTL so we can get rid of ATL since it causes many problems. See bug for details. BUG=5027 TEST=chrome runs. Accessibility works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275987 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276360

Patch Set 1 #

Patch Set 2 : BrowserAccessibilityTest fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M content/app/content_main_runner.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
cpu_(ooo_6.6-7.5)
ptal.
6 years, 6 months ago (2014-06-07 21:30:56 UTC) #1
jam
lgtm
6 years, 6 months ago (2014-06-09 15:40:49 UTC) #2
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 6 months ago (2014-06-09 20:47:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/323723002/1
6 years, 6 months ago (2014-06-09 20:49:06 UTC) #4
commit-bot: I haz the power
Change committed as 275987
6 years, 6 months ago (2014-06-10 11:20:40 UTC) #5
alph
A revert of this CL has been created in https://codereview.chromium.org/323003007/ by alph@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-10 16:00:53 UTC) #6
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 6 months ago (2014-06-11 01:05:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/323723002/20001
6 years, 6 months ago (2014-06-11 01:09:19 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 12:13:27 UTC) #9
Message was sent while issue was closed.
Change committed as 276360

Powered by Google App Engine
This is Rietveld 408576698