Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323693002: Split printing utility IPC messages into its own file. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tfarina, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Split printing utility IPC messages into its own file. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278042

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : rebase, fix win #

Patch Set 4 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+860 lines, -738 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/pwg_raster_converter.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/printing/pdf_to_emf_converter.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 chunks +34 lines, -15 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_utility.gypi View 1 2 3 chunks +16 lines, -6 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 2 7 chunks +0 lines, -122 lines 0 comments Download
A chrome/common/chrome_utility_printing_messages.h View 1 2 1 chunk +150 lines, -0 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 4 chunks +5 lines, -1 line 0 comments Download
M chrome/test/base/chrome_unit_test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.h View 5 chunks +0 lines, -49 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 13 chunks +13 lines, -510 lines 0 comments Download
M chrome/utility/chrome_content_utility_ipc_whitelist.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/utility/chrome_content_utility_ipc_whitelist.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/utility/image_writer/image_writer_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/local_discovery/service_discovery_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/media_galleries/ipc_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/utility/printing_handler.h View 1 chunk +76 lines, -0 lines 0 comments Download
A chrome/utility/printing_handler.cc View 1 chunk +536 lines, -0 lines 0 comments Download
M chrome/utility/profile_import_handler.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/utility/profile_import_handler.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/utility/utility_message_handler.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ipc/ipc_message_start.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Lei Zhang
I'd like to split off the printing and extensions utility handlers from ChromeContentUtilityClient. Please take ...
6 years, 6 months ago (2014-06-09 19:25:09 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/323693002/diff/60001/chrome/utility/printing_handler.cc File chrome/utility/printing_handler.cc (right): https://codereview.chromium.org/323693002/diff/60001/chrome/utility/printing_handler.cc#newcode477 chrome/utility/printing_handler.cc:477: case printing::TRANSFORM_FLIP_VERTICAL: This code just moved?
6 years, 6 months ago (2014-06-09 21:19:46 UTC) #2
Lei Zhang
https://codereview.chromium.org/323693002/diff/60001/chrome/utility/printing_handler.cc File chrome/utility/printing_handler.cc (right): https://codereview.chromium.org/323693002/diff/60001/chrome/utility/printing_handler.cc#newcode477 chrome/utility/printing_handler.cc:477: case printing::TRANSFORM_FLIP_VERTICAL: On 2014/06/09 21:19:45, Vitaly Buka wrote: > ...
6 years, 6 months ago (2014-06-11 20:49:08 UTC) #3
Lei Zhang
+palmer for IPC changes.
6 years, 6 months ago (2014-06-11 20:49:25 UTC) #4
palmer
lgtm
6 years, 6 months ago (2014-06-11 21:21:16 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-12 05:05:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/323693002/80001
6 years, 6 months ago (2014-06-12 05:09:28 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 10:12:52 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 11:14:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/19171)
6 years, 6 months ago (2014-06-12 11:15:00 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-17 23:41:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/323693002/120001
6 years, 6 months ago (2014-06-17 23:43:02 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 12:05:14 UTC) #13
Message was sent while issue was closed. 
Change committed as 278042

Powered by Google App Engine
This is Rietveld 408576698