base/files/file_posix.cc - Issue 323683002: net: FileStream cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_posix.cc

Issue 323683002: net: FileStream cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_posix.cc

diff --git a/base/files/file_posix.cc b/base/files/file_posix.cc

index 0764ee98660239ed813ada6d0dd0a7b15429aeee..4451210eca5d457ceafd5022714ebbf97b69b53c 100644

--- a/base/files/file_posix.cc

+++ b/base/files/file_posix.cc

@@ -280,8 +280,6 @@ void File::Close() {

int64 File::Seek(Whence whence, int64 offset) {

base::ThreadRestrictions::AssertIOAllowed();

DCHECK(IsValid());

- if (offset < 0)

- return -1;

return lseek(file_.get(), static_cast<off_t>(offset),

static_cast<int>(whence));

« no previous file with comments | « no previous file | base/files/file_unittest.cc » ('j') | net/base/file_stream_context_posix.cc » ('J')