Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: net/base/file_stream_unittest.cc

Issue 323683002: net: FileStream cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/file_stream_unittest.cc
diff --git a/net/base/file_stream_unittest.cc b/net/base/file_stream_unittest.cc
index 292b0d207cfff37320e34e72fc53e25725302437..06e23bb825de107d062b638f4a2d3c6e8b4119e5 100644
--- a/net/base/file_stream_unittest.cc
+++ b/net/base/file_stream_unittest.cc
@@ -120,7 +120,8 @@ TEST_F(FileStreamTest, UseFileHandle) {
scoped_ptr<FileStream> read_stream(
new FileStream(file.Pass(), base::MessageLoopProxy::current()));
ASSERT_EQ(ERR_IO_PENDING,
- read_stream->Seek(FROM_BEGIN, 0, callback64.callback()));
+ read_stream->Seek(base::File::FROM_BEGIN, 0,
+ callback64.callback()));
ASSERT_EQ(0, callback64.WaitForResult());
// Read into buffer and compare.
scoped_refptr<IOBufferWithSize> read_buffer =
@@ -139,7 +140,8 @@ TEST_F(FileStreamTest, UseFileHandle) {
scoped_ptr<FileStream> write_stream(
new FileStream(file.Pass(), base::MessageLoopProxy::current()));
ASSERT_EQ(ERR_IO_PENDING,
- write_stream->Seek(FROM_BEGIN, 0, callback64.callback()));
+ write_stream->Seek(base::File::FROM_BEGIN, 0,
+ callback64.callback()));
ASSERT_EQ(0, callback64.WaitForResult());
scoped_refptr<IOBufferWithSize> write_buffer = CreateTestDataBuffer();
rv = write_stream->Write(write_buffer.get(), kTestDataSize,
@@ -164,7 +166,7 @@ TEST_F(FileStreamTest, UseClosedStream) {
EXPECT_FALSE(stream.IsOpen());
// Try seeking...
- rv = stream.Seek(FROM_BEGIN, 5, callback64.callback());
+ rv = stream.Seek(base::File::FROM_BEGIN, 5, callback64.callback());
EXPECT_EQ(ERR_UNEXPECTED, callback64.GetResult(rv));
// Try reading...
@@ -243,7 +245,7 @@ TEST_F(FileStreamTest, AsyncRead_FromOffset) {
TestInt64CompletionCallback callback64;
const int64 kOffset = 3;
- rv = stream.Seek(FROM_BEGIN, kOffset, callback64.callback());
+ rv = stream.Seek(base::File::FROM_BEGIN, kOffset, callback64.callback());
ASSERT_EQ(ERR_IO_PENDING, rv);
int64 new_offset = callback64.WaitForResult();
EXPECT_EQ(kOffset, new_offset);
@@ -278,24 +280,24 @@ TEST_F(FileStreamTest, AsyncSeekAround) {
TestInt64CompletionCallback callback64;
const int64 kOffset = 3;
- rv = stream.Seek(FROM_BEGIN, kOffset, callback64.callback());
+ rv = stream.Seek(base::File::FROM_BEGIN, kOffset, callback64.callback());
ASSERT_EQ(ERR_IO_PENDING, rv);
int64 new_offset = callback64.WaitForResult();
EXPECT_EQ(kOffset, new_offset);
- rv = stream.Seek(FROM_CURRENT, kOffset, callback64.callback());
+ rv = stream.Seek(base::File::FROM_CURRENT, kOffset, callback64.callback());
ASSERT_EQ(ERR_IO_PENDING, rv);
new_offset = callback64.WaitForResult();
EXPECT_EQ(2 * kOffset, new_offset);
- rv = stream.Seek(FROM_CURRENT, -kOffset, callback64.callback());
+ rv = stream.Seek(base::File::FROM_CURRENT, -kOffset, callback64.callback());
ASSERT_EQ(ERR_IO_PENDING, rv);
new_offset = callback64.WaitForResult();
EXPECT_EQ(kOffset, new_offset);
const int kTestDataLen = arraysize(kTestData) - 1;
- rv = stream.Seek(FROM_END, -kTestDataLen, callback64.callback());
+ rv = stream.Seek(base::File::FROM_END, -kTestDataLen, callback64.callback());
ASSERT_EQ(ERR_IO_PENDING, rv);
new_offset = callback64.WaitForResult();
EXPECT_EQ(0, new_offset);
@@ -376,7 +378,7 @@ TEST_F(FileStreamTest, AsyncWrite_FromOffset) {
TestInt64CompletionCallback callback64;
const int64 kOffset = 0;
- rv = stream.Seek(FROM_END, kOffset, callback64.callback());
+ rv = stream.Seek(base::File::FROM_END, kOffset, callback64.callback());
ASSERT_EQ(ERR_IO_PENDING, rv);
int64 new_offset = callback64.WaitForResult();
EXPECT_EQ(kTestDataSize, new_offset);
@@ -468,7 +470,7 @@ TEST_F(FileStreamTest, BasicAsyncWriteRead) {
EXPECT_EQ(OK, callback.WaitForResult());
TestInt64CompletionCallback callback64;
- rv = stream->Seek(FROM_END, 0, callback64.callback());
+ rv = stream->Seek(base::File::FROM_END, 0, callback64.callback());
ASSERT_EQ(ERR_IO_PENDING, rv);
int64 offset = callback64.WaitForResult();
EXPECT_EQ(offset, file_size);
@@ -492,7 +494,7 @@ TEST_F(FileStreamTest, BasicAsyncWriteRead) {
EXPECT_EQ(kTestDataSize, total_bytes_written);
- rv = stream->Seek(FROM_BEGIN, 0, callback64.callback());
+ rv = stream->Seek(base::File::FROM_BEGIN, 0, callback64.callback());
ASSERT_EQ(ERR_IO_PENDING, rv);
offset = callback64.WaitForResult();
EXPECT_EQ(0, offset);
@@ -577,7 +579,8 @@ class TestWriteReadCompletionCallback {
} else { // We're done writing all data. Start reading the data.
TestInt64CompletionCallback callback64;
EXPECT_EQ(ERR_IO_PENDING,
- stream_->Seek(FROM_BEGIN, 0, callback64.callback()));
+ stream_->Seek(base::File::FROM_BEGIN, 0,
+ callback64.callback()));
{
base::MessageLoop::ScopedNestableTaskAllower allow(
base::MessageLoop::current());
@@ -635,7 +638,8 @@ TEST_F(FileStreamTest, AsyncWriteRead) {
EXPECT_EQ(OK, open_callback.WaitForResult());
TestInt64CompletionCallback callback64;
- EXPECT_EQ(ERR_IO_PENDING, stream->Seek(FROM_END, 0, callback64.callback()));
+ EXPECT_EQ(ERR_IO_PENDING,
+ stream->Seek(base::File::FROM_END, 0, callback64.callback()));
EXPECT_EQ(file_size, callback64.WaitForResult());
int total_bytes_written = 0;
@@ -739,7 +743,8 @@ TEST_F(FileStreamTest, AsyncWriteClose) {
EXPECT_EQ(OK, open_callback.WaitForResult());
TestInt64CompletionCallback callback64;
- EXPECT_EQ(ERR_IO_PENDING, stream->Seek(FROM_END, 0, callback64.callback()));
+ EXPECT_EQ(ERR_IO_PENDING,
+ stream->Seek(base::File::FROM_END, 0, callback64.callback()));
EXPECT_EQ(file_size, callback64.WaitForResult());
int total_bytes_written = 0;

Powered by Google App Engine
This is Rietveld 408576698