chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc - Issue 323683002: net: FileStream cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

Issue 323683002: net: FileStream cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/messaging/native_message_process_host.h ('K') | « chrome/browser/extensions/api/messaging/native_message_process_host.cc ('k') | net/base/file_stream.h » ('j') | net/base/file_stream.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

index 81e811ba273b661a580901a07faf2e4190c067ab..11e23c671e484630d02392642c2a9e36833cd67a 100644

--- a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

+++ b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

@@ -184,14 +184,10 @@ TEST_F(NativeMessagingTest, SingleSendMessageRead) {

AsWeakPtr(), ScopedTestNativeMessagingHost::kExtensionId, "empty_app.py",

0, launcher.Pass());

ASSERT_TRUE(native_message_process_host_.get());

+ native_message_process_host_->DontWaitToReadForTesting();

run_loop_.reset(new base::RunLoop());

- run_loop_->RunUntilIdle();

+ run_loop_->Run();

- if (last_message_.empty()) {

- run_loop_.reset(new base::RunLoop());

- native_message_process_host_->ReadNowForTesting();

- run_loop_->Run();

- }

EXPECT_EQ(kTestMessage, last_message_);

}