Delete CompositingUpdateAfterLayout

Delete CompositingUpdateAfterLayout

Rather than using a different update type, we can just mark the root as needing
its properties updated, which will cause us to update the entire tree. This CL
alone isn't a huge win, but it will let us remove
RenderLayerCompositor::m_compositingLayersNeedRebuild in the next CL.

Also, move the call to enableCompositingModeIfNeeded into the new
RenderLayerCompositor::didLayout function. This makes the sequence look a bit
silly (because we mark the dirty bit only to clear it immediately), but that's
what the code did before (albeit in a more roundabout way).

BUG=332248
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175738

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175752

[esprehn, 2014-06-06 23:27:12]

lgtm

[abarth-chromium, 2014-06-07 04:56:03]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-07 04:56:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/323653002/1

[commit-bot: I haz the power, 2014-06-07 06:02:55]

Change committed as 175738

[dcheng, 2014-06-07 09:13:31]

A revert of this CL has been created in
https://codereview.chromium.org/321663002/ by dcheng@chromium.org.

The reason for reverting is: Triggers ASSERT when running browser_test
CastStreamingApiTestWithPixelOutput.RtpStreamError.

[abarth-chromium, 2014-06-07 09:53:16]

Here's the stack.  RenderMarquee: O_o

#3 0x000005b0d325 WebCore::RenderLayerCompositor::inCompositingMode()
#4 0x000005a4c777 WebCore::RenderLayerScrollableArea::setScrollOffset()
#5 0x0000047c7b56 WebCore::ScrollableArea::scrollPositionChanged()
#6 0x0000047c7f05 WebCore::ScrollableArea::setScrollOffsetFromAnimation()
#7 0x0000047f89cf WebCore::ScrollAnimator::notifyPositionChanged()
#8 0x0000047f84b5 WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation()
#9 0x0000047c7920 WebCore::ScrollableArea::scrollToOffsetWithoutAnimation()
#10 0x000005a4d605 WebCore::RenderLayerScrollableArea::scrollToOffset()
#11 0x000005a68324 WebCore::RenderMarquee::start()
#12 0x000005a68558 WebCore::RenderMarquee::updateMarqueePosition()
#13 0x000005a68973 WebCore::RenderMarquee::layoutBlock()
#14 0x00000594d410 WebCore::RenderBlock::layout()
#15 0x000005964009 WebCore::RenderObject::layoutIfNeeded()
#16 0x000005992c16 WebCore::RenderBlockFlow::layoutInlineChildren()
#17 0x0000059876cd WebCore::RenderBlockFlow::layoutBlockFlow()
#18 0x000005978282 WebCore::RenderBlockFlow::layoutBlock()
#19 0x00000594d410 WebCore::RenderBlock::layout()
#20 0x000005978e2c WebCore::RenderBlockFlow::layoutBlockChild()
#21 0x00000597ac2e WebCore::RenderBlockFlow::layoutBlockChildren()
#22 0x0000059876fb WebCore::RenderBlockFlow::layoutBlockFlow()
#23 0x000005978282 WebCore::RenderBlockFlow::layoutBlock()
#24 0x00000594d410 WebCore::RenderBlock::layout()
#25 0x000005978e2c WebCore::RenderBlockFlow::layoutBlockChild()
#26 0x00000597ac2e WebCore::RenderBlockFlow::layoutBlockChildren()
#27 0x0000059876fb WebCore::RenderBlockFlow::layoutBlockFlow()
#28 0x000005978282 WebCore::RenderBlockFlow::layoutBlock()
#29 0x00000594d410 WebCore::RenderBlock::layout()
#30 0x000005ae16d6 WebCore::RenderView::layoutContent()
#31 0x000005ae1d2e WebCore::RenderView::layout()
#32 0x0000056122ca WebCore::FrameView::performLayout()
#33 0x0000056131b7 WebCore::FrameView::layout()
#34 0x000004e8e62d WebCore::Document::implicitClose()
#35 0x0000056f2372 WebCore::FrameLoader::checkCompleted()
#36 0x0000056f20d2 WebCore::FrameLoader::loadDone()
#37 0x0000055dd0b5 WebCore::ResourceFetcher::didLoadResource()
#38 0x0000055ea5bb WebCore::ResourceLoader::releaseResources()
#39 0x0000055ec1a3 WebCore::ResourceLoader::didFinishLoading()
#40 0x0000084039fa content::WebURLLoaderImpl::Context::OnCompletedRequest()
#41 0x0000083d6ef1 content::ResourceDispatcher::OnRequestComplete()
#42 0x0000083dafa5 DispatchToMethod<>()
#43 0x0000083d9b54 ResourceMsg_RequestComplete::Dispatch<>()
#44 0x0000083d8146 content::ResourceDispatcher::DispatchMessage()
#45 0x0000083d5a6f content::ResourceDispatcher::OnMessageReceived()
#46 0x00000833773c content::ChildThread::OnMessageReceived()
#47 0x000003b57174 IPC::ChannelProxy::Context::OnDispatchMessage()
#48 0x000003b5bb56 base::internal::RunnableAdapter<>::Run()
#49 0x000003b5b234 base::internal::InvokeHelper<>::MakeItSo()
#50 0x000003b5a2e4 base::internal::Invoker<>::Run()
#51 0x0000005307eb base::Callback<>::Run()
#52 0x0000020d68e8 base::MessageLoop::RunTask()
#53 0x0000020d6a0c base::MessageLoop::DeferOrRunPendingTask()
#54 0x0000020d6f33 base::MessageLoop::DoWork()
#55 0x0000020e6f8a base::MessagePumpDefault::Run()
#56 0x0000020d6437 base::MessageLoop::RunHandler()
#57 0x000002110176 base::RunLoop::Run()
#58 0x0000020d5ba6 base::MessageLoop::Run()
#59 0x00000a1915da content::RendererMain()
#60 0x000009f1d3bb content::RunZygote()
#61 0x000009f1d611 content::RunNamedProcessTypeMain()

[abarth-chromium, 2014-06-07 23:53:03]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-07 23:53:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/323653002/20001

[commit-bot: I haz the power, 2014-06-08 00:57:22]

Change committed as 175752