Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 323643003: Revert of [Telemetry] Disable DCHECK crashes in release builds. (Closed)

Created:
6 years, 6 months ago by tonyg
Modified:
6 years, 6 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Revert of [Telemetry] Disable DCHECK crashes in release builds. (https://codereview.chromium.org/322593004/) Reason for revert: Did not have the desired effect. Original issue's description: > [Telemetry] Disable DCHECK crashes in release builds. > > Telemetry is designed for performance, not functional testing and it is > currently bearing more of the weight of these failures than the infra can > handle. > > NOTRY=True > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275580 TBR=dtu@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
Created Revert of [Telemetry] Disable DCHECK crashes in release builds.
6 years, 6 months ago (2014-06-07 02:01:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/323643003/1
6 years, 6 months ago (2014-06-07 02:03:15 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 02:05:28 UTC) #3
Message was sent while issue was closed.
Change committed as 275588

Powered by Google App Engine
This is Rietveld 408576698