Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 323633003: Change tabs + sessions permission warning (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/permissions/chrome_permission_message_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
===================================================================
--- chrome/common/extensions/permissions/permission_set_unittest.cc (revision 275837)
+++ chrome/common/extensions/permissions/permission_set_unittest.cc (working copy)
@@ -975,6 +975,55 @@
EXPECT_TRUE(Contains(warnings, "Use your camera"));
}
+TEST(PermissionsTest, GetWarningMessages_CombinedSessions) {
+ {
+ APIPermissionSet api_permissions;
+ api_permissions.insert(APIPermission::kTab);
+ api_permissions.insert(APIPermission::kSessions);
+ scoped_refptr<PermissionSet> permissions(
+ new PermissionSet(api_permissions, ManifestPermissionSet(),
+ URLPatternSet(), URLPatternSet()));
+ std::vector<base::string16> messages =
+ PermissionMessageProvider::Get()->GetWarningMessages(
+ permissions, Manifest::TYPE_EXTENSION);
+ EXPECT_EQ(1u, messages.size());
+ EXPECT_EQ(l10n_util::GetStringUTF16(
+ IDS_EXTENSION_PROMPT_WARNING_TABS_AND_SESSIONS),
+ messages[0]);
+ }
+ {
+ APIPermissionSet api_permissions;
+ api_permissions.insert(APIPermission::kHistory);
+ api_permissions.insert(APIPermission::kSessions);
+ scoped_refptr<PermissionSet> permissions(
+ new PermissionSet(api_permissions, ManifestPermissionSet(),
+ URLPatternSet(), URLPatternSet()));
+ std::vector<base::string16> messages =
+ PermissionMessageProvider::Get()->GetWarningMessages(
+ permissions, Manifest::TYPE_EXTENSION);
+ EXPECT_EQ(1u, messages.size());
+ EXPECT_EQ(l10n_util::GetStringUTF16(
+ IDS_EXTENSION_PROMPT_WARNING_BROWSING_HISTORY_AND_SESSIONS),
+ messages[0]);
+ }
+ {
+ APIPermissionSet api_permissions;
+ api_permissions.insert(APIPermission::kTab);
+ api_permissions.insert(APIPermission::kHistory);
+ api_permissions.insert(APIPermission::kSessions);
+ scoped_refptr<PermissionSet> permissions(
+ new PermissionSet(api_permissions, ManifestPermissionSet(),
+ URLPatternSet(), URLPatternSet()));
+ std::vector<base::string16> messages =
+ PermissionMessageProvider::Get()->GetWarningMessages(
+ permissions, Manifest::TYPE_EXTENSION);
+ EXPECT_EQ(1u, messages.size());
+ EXPECT_EQ(l10n_util::GetStringUTF16(
+ IDS_EXTENSION_PROMPT_WARNING_BROWSING_HISTORY_AND_SESSIONS),
+ messages[0]);
+ }
+}
+
TEST(PermissionsTest, GetWarningMessages_DeclarativeWebRequest) {
// Test that if the declarativeWebRequest permission is present
// in combination with all hosts permission, then only the warning
« no previous file with comments | « chrome/common/extensions/permissions/chrome_permission_message_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698