Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323593002: Mojo: Use network service to load non-local Mojo Apps. (Closed)

Created:
6 years, 6 months ago by darin (slow to review)
Modified:
6 years, 6 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Use network service to load non-local Mojo Apps. R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276047

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : Add back support for --origin #

Patch Set 4 : updates #

Total comments: 1

Patch Set 5 : fix clang build #

Patch Set 6 : remove TODO about kDisableCache #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -623 lines) Patch
A mojo/common/data_pipe_utils.h View 1 chunk +32 lines, -0 lines 0 comments Download
A mojo/common/data_pipe_utils.cc View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 5 6 3 chunks +7 lines, -10 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_impl.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/network/url_loader.mojom View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/shell/app_child_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/context.h View 1 2 3 chunks +3 lines, -13 lines 0 comments Download
M mojo/shell/context.cc View 1 2 3 3 chunks +11 lines, -8 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M mojo/shell/dynamic_service_loader.h View 3 chunks +3 lines, -11 lines 0 comments Download
M mojo/shell/dynamic_service_loader.cc View 1 2 3 4 2 chunks +132 lines, -72 lines 0 comments Download
M mojo/shell/in_process_dynamic_service_runner.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/in_process_dynamic_service_runner.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/shell/keep_alive.cc View 1 chunk +1 line, -0 lines 0 comments Download
D mojo/shell/loader.h View 1 chunk +0 lines, -74 lines 0 comments Download
D mojo/shell/loader.cc View 1 chunk +0 lines, -93 lines 0 comments Download
A mojo/shell/mojo_url_resolver.h View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A mojo/shell/mojo_url_resolver.cc View 1 2 3 4 1 chunk +70 lines, -0 lines 0 comments Download
D mojo/shell/network_delegate.h View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/shell/network_delegate.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M mojo/shell/out_of_process_dynamic_service_runner.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/out_of_process_dynamic_service_runner.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/run.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/shell/shell_test_base.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
D mojo/shell/storage.h View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/shell/storage.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M mojo/shell/switches.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/shell/task_runners.h View 2 chunks +0 lines, -10 lines 0 comments Download
M mojo/shell/task_runners.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/shell/url_request_context_getter.h View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/shell/url_request_context_getter.cc View 1 chunk +0 lines, -133 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
darin (slow to review)
6 years, 6 months ago (2014-06-06 18:35:47 UTC) #1
DaveMoore
https://codereview.chromium.org/323593002/diff/60001/mojo/shell/switches.cc File mojo/shell/switches.cc (right): https://codereview.chromium.org/323593002/diff/60001/mojo/shell/switches.cc#newcode14 mojo/shell/switches.cc:14: // instructions. TODO(darin): Pass this along to the NetworkService ...
6 years, 6 months ago (2014-06-09 16:26:41 UTC) #2
darin (slow to review)
Sorry, that TODO comment just needs to be deleted. Take a look at the code ...
6 years, 6 months ago (2014-06-09 16:28:01 UTC) #3
DaveMoore
lgtm
6 years, 6 months ago (2014-06-09 16:33:40 UTC) #4
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 6 months ago (2014-06-09 17:22:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/323593002/100001
6 years, 6 months ago (2014-06-09 17:24:47 UTC) #6
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 6 months ago (2014-06-10 00:06:57 UTC) #7
darin (slow to review)
The CQ bit was unchecked by darin@chromium.org
6 years, 6 months ago (2014-06-10 00:07:09 UTC) #8
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 6 months ago (2014-06-10 04:31:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/323593002/120001
6 years, 6 months ago (2014-06-10 04:35:51 UTC) #10
darin (slow to review)
6 years, 6 months ago (2014-06-10 16:13:04 UTC) #11
Message was sent while issue was closed. 
Committed patchset #7 manually as r276047 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698