Issue 323563006: Updated PrivetV3SetupFlow API.

Issue 323563006: Updated PrivetV3SetupFlow API. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 6 months ago

Reviewers:
Noam Samuel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Updated PrivetV3SetupFlow API. BUG=372843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275603

Patch Set 2 : Fri 06/06/2014 15:33:47.30 #

Total comments: 4

Patch Set 3 : Fri 06/06/2014 16:20:01.01 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -45 lines)			Patch
	M	chrome/browser/local_discovery/privetv3_setup_flow.h	View	1 2	1 chunk	+47 lines, -32 lines	0 comments	Download
	M	chrome/browser/local_discovery/privetv3_setup_flow.cc	View	1	1 chunk	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Noam Samuel

lgtm https://codereview.chromium.org/323563006/diff/20001/chrome/browser/local_discovery/privetv3_setup_flow.h File chrome/browser/local_discovery/privetv3_setup_flow.h (right): https://codereview.chromium.org/323563006/diff/20001/chrome/browser/local_discovery/privetv3_setup_flow.h#newcode24 chrome/browser/local_discovery/privetv3_setup_flow.h:24: typedef base::Callback<void(const std::string& ssid, Add comment explaining empty ...

6 years, 6 months ago (2014-06-06 23:14:49 UTC) #2

Vitaly Buka (NO REVIEWS)

https://codereview.chromium.org/323563006/diff/20001/chrome/browser/local_discovery/privetv3_setup_flow.h File chrome/browser/local_discovery/privetv3_setup_flow.h (right): https://codereview.chromium.org/323563006/diff/20001/chrome/browser/local_discovery/privetv3_setup_flow.h#newcode24 chrome/browser/local_discovery/privetv3_setup_flow.h:24: typedef base::Callback<void(const std::string& ssid, On 2014/06/06 23:14:48, Noam Samuel ...

6 years, 6 months ago (2014-06-06 23:20:31 UTC) #3

Vitaly Buka (NO REVIEWS)

The CQ bit was checked by vitalybuka@chromium.org

6 years, 6 months ago (2014-06-06 23:20:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/323563006/40001

6 years, 6 months ago (2014-06-06 23:23:00 UTC) #5

Message was sent while issue was closed.

Change committed as 275603

Expand Messages | Collapse Messages