Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 323563005: Enable DirectWrite by default (Closed)

Created:
6 years, 6 months ago by scottmg
Modified:
6 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Enable DirectWrite by default Flips the sense of the flag for now. If all seems OK as we move through channels, I will remove it later. R=cpu@chromium.org, jam@chromium.org BUG=25541 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scottmg
cpu: chrome/app/generated_resources.grd chrome/browser/about_flags.cc content/common/sandbox_win.cc jam: content/browser/renderer_host/render_process_host_impl.cc content/public/common/content_switches.*
6 years, 6 months ago (2014-06-06 22:28:22 UTC) #1
eae
Yay!
6 years, 6 months ago (2014-06-06 22:30:12 UTC) #2
eae
We might want to keep a --disable-direct-write flag for content_shell (and only for content shell) ...
6 years, 6 months ago (2014-06-06 22:31:12 UTC) #3
scottmg
Ah, do we need to land --disable-direct-write somewhere in Blink first to avoid breaking layout_test ...
6 years, 6 months ago (2014-06-06 22:48:07 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
6 years, 6 months ago (2014-06-07 00:58:40 UTC) #5
eae
On 2014/06/06 22:48:07, scottmg wrote: > Ah, do we need to land --disable-direct-write somewhere in ...
6 years, 6 months ago (2014-06-07 19:11:39 UTC) #6
jam
lgtm
6 years, 6 months ago (2014-06-09 15:38:54 UTC) #7
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 6 months ago (2014-06-09 15:53:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/323563005/1
6 years, 6 months ago (2014-06-09 15:54:50 UTC) #9
scottmg
6 years, 6 months ago (2014-06-09 21:47:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r275860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698