Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323503002: Devtools: Support disabling and enabling of debugger in TargetBreakpoints (Closed)

Created:
6 years, 6 months ago by sergeyv
Modified:
6 years, 6 months ago
Reviewers:
vsevik, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

[WIP]Devtools: Support disabling and enabling of debugger in TargetBreakpoints BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175897

Patch Set 1 #

Patch Set 2 : Test added #

Patch Set 3 : Test that adds/removes breakpoint while debugger is turned off #

Total comments: 4

Patch Set 4 : Remove setTimeouts #

Total comments: 6

Patch Set 5 : Address vsevik's comments #

Patch Set 6 : Rebase on master #

Patch Set 7 : Fix expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -3 lines) Patch
M LayoutTests/inspector/sources/debugger/breakpoint-manager.js View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint-expected.txt View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-disable-enable.html View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-disable-enable-expected.txt View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/BreakpointManager.js View 1 2 3 4 5 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
sergeyv
6 years, 6 months ago (2014-06-06 13:40:25 UTC) #1
loislo
On 2014/06/06 13:40:25, sergeyv wrote: it need a test which checks that breakpoint restores.
6 years, 6 months ago (2014-06-06 13:52:21 UTC) #2
loislo
https://codereview.chromium.org/323503002/diff/40001/LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html File LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html (right): https://codereview.chromium.org/323503002/diff/40001/LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html#newcode16 LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html:16: setTimeout(InspectorTest.completeDebuggerTest, 1000); Please remove this. Test harness already have ...
6 years, 6 months ago (2014-06-06 18:00:21 UTC) #3
sergeyv
https://codereview.chromium.org/323503002/diff/40001/LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html File LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html (right): https://codereview.chromium.org/323503002/diff/40001/LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html#newcode16 LayoutTests/inspector/sources/debugger/debugger-disable-add-breakpoint.html:16: setTimeout(InspectorTest.completeDebuggerTest, 1000); On 2014/06/06 18:00:21, loislo wrote: > Please ...
6 years, 6 months ago (2014-06-09 09:08:02 UTC) #4
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 6 months ago (2014-06-09 09:08:29 UTC) #5
sergeyv
The CQ bit was unchecked by sergeyv@chromium.org
6 years, 6 months ago (2014-06-09 09:08:29 UTC) #6
vsevik
lgtm https://chromiumcodereview.appspot.com/323503002/diff/60001/Source/devtools/front_end/sdk/BreakpointManager.js File Source/devtools/front_end/sdk/BreakpointManager.js (right): https://chromiumcodereview.appspot.com/323503002/diff/60001/Source/devtools/front_end/sdk/BreakpointManager.js#newcode784 Source/devtools/front_end/sdk/BreakpointManager.js:784: _removeLocally: function() cleanUpAfterDebuggerIsGone https://chromiumcodereview.appspot.com/323503002/diff/60001/Source/devtools/front_end/sdk/BreakpointManager.js#newcode796 Source/devtools/front_end/sdk/BreakpointManager.js:796: if (locally) Let's ...
6 years, 6 months ago (2014-06-10 09:16:22 UTC) #7
sergeyv
https://codereview.chromium.org/323503002/diff/60001/Source/devtools/front_end/sdk/BreakpointManager.js File Source/devtools/front_end/sdk/BreakpointManager.js (right): https://codereview.chromium.org/323503002/diff/60001/Source/devtools/front_end/sdk/BreakpointManager.js#newcode784 Source/devtools/front_end/sdk/BreakpointManager.js:784: _removeLocally: function() On 2014/06/10 09:16:22, vsevik wrote: > cleanUpAfterDebuggerIsGone ...
6 years, 6 months ago (2014-06-10 11:14:37 UTC) #8
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 6 months ago (2014-06-10 11:14:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/323503002/80001
6 years, 6 months ago (2014-06-10 11:15:08 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 11:15:23 UTC) #11
commit-bot: I haz the power
Failed to apply patch for LayoutTests/inspector/sources/debugger/breakpoint-manager.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-10 11:15:24 UTC) #12
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 6 months ago (2014-06-10 12:12:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/323503002/100001
6 years, 6 months ago (2014-06-10 12:13:33 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-10 13:22:26 UTC) #15
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 6 months ago (2014-06-10 13:49:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/323503002/120001
6 years, 6 months ago (2014-06-10 13:50:16 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 15:09:29 UTC) #18
Message was sent while issue was closed. 
Change committed as 175897

Powered by Google App Engine
This is Rietveld 408576698