Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 323483002: Remove non-recipe builders from tryserver.chromium that have recipe equivalents (Closed)

Created:
6 years, 6 months ago by Paweł Hajdan Jr.
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove non-recipe builders from tryserver.chromium that have recipe equivalents linux -> linux_chromium_dbg linux_rel -> linux_chromium_rel mac -> mac_chromium_dbg mac_rel -> mac_chromium_rel win -> win_chromium_dbg win_rel -> win_chromium_rel win_x64_rel -> win_chromium_x64_rel linux_chromeos > linux_chromium_chromeos_rel linux_clang -> linux_chromium_clang_dbg linux_chromeos_clang -> linux_chromium_chromeos_clang_dbg BUG=380709 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=275799

Patch Set 1 #

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -180 lines) Patch
M masters/master.tryserver.chromium/master.cfg View 1 9 chunks +2 lines, -172 lines 0 comments Download
M masters/master.tryserver.chromium/slaves.cfg View 1 5 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Paweł Hajdan Jr.
Please review. PSA draft is at https://goto.google.com/dfuji (Google-internal).
6 years, 6 months ago (2014-06-06 14:04:22 UTC) #1
Peter Mayo
LGTM ++Yay for the sanity. I can't think of a good way to reduce the ...
6 years, 6 months ago (2014-06-06 14:14:40 UTC) #2
cmp
Can you confirm that PRESUBMIT.py doesn't reference any of these bots? Can you confirm the ...
6 years, 6 months ago (2014-06-06 16:54:14 UTC) #3
Sergey Berezin
On 2014/06/06 16:54:14, cmp wrote: > Can you confirm that PRESUBMIT.py doesn't reference any of ...
6 years, 6 months ago (2014-06-06 21:44:06 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/320823002 removes last references to the bots from PRESUBMIT.py (note that they had to be ...
6 years, 6 months ago (2014-06-09 12:49:37 UTC) #5
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 6 months ago (2014-06-09 12:49:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/323483002/2
6 years, 6 months ago (2014-06-09 12:49:59 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 12:50:23 UTC) #8
Message was sent while issue was closed.
Change committed as 275799

Powered by Google App Engine
This is Rietveld 408576698