Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 32343006: Turn the flag off and see what happens (Closed)

Created:
7 years, 2 months ago by awong
Modified:
6 years, 10 months ago
Reviewers:
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Turn the flag off and see what happens BUG=

Patch Set 1 #

Patch Set 2 : nasko's change #

Patch Set 3 : Correct parent() conditional #

Patch Set 4 : Make FrameDetach message go through. #

Patch Set 5 : redo main frame client lifetime. fuuuuuu #

Patch Set 6 : disable tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -47 lines) Patch
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 1 2 3 4 5 7 chunks +7 lines, -7 lines 0 comments Download
M content/common/swapped_out_messages.cc View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 2 chunks +26 lines, -32 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698