Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 323423008: Revert r174436 (Reduce the cost of the n^2 loop in collectTreeBoundaryCrossingRules) (Closed)

Created:
6 years, 6 months ago by kochi
Modified:
6 years, 6 months ago
Reviewers:
esprehn, hayato, tasak
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Revert r174436 (Reduce the cost of the n^2 loop in collectTreeBoundaryCrossingRules) https://src.chromium.org/viewvc/blink?view=rev&revision=174436 r174436 was introduced to improve the performance, but introduced some regressions for shadow styling. Added a layout test based on the report in issue 383366 to prevent the same regression again. BUG=383366, 372083 TEST=pass all layout tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176099

Patch Set 1 : Add a layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
A LayoutTests/fast/css/content-distributed-nodes.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/content-distributed-nodes-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/css/TreeBoundaryCrossingRules.cpp View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kochi
Hi Takashi, Elliott, While looking issue 383366, I found r174436 was causing the regression. As ...
6 years, 6 months ago (2014-06-13 06:24:42 UTC) #1
hayato
lgtm
6 years, 6 months ago (2014-06-13 06:31:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/323423008/20001
6 years, 6 months ago (2014-06-13 06:32:24 UTC) #3
commit-bot: I haz the power
Change committed as 176099
6 years, 6 months ago (2014-06-13 08:40:36 UTC) #4
esprehn
6 years, 6 months ago (2014-06-13 08:57:02 UTC) #5
Message was sent while issue was closed.
On 2014/06/13 at 08:40:36, commit-bot wrote:
> Change committed as 176099

Thanks for reverting this. Looks like we need to really fix it for good, hacks
aren't going to work. Also you're amazing for adding a test!

Powered by Google App Engine
This is Rietveld 408576698