Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 323423003: ARM: Avoid duplicate vmla when merging vmul and vadd (Closed)

Created:
6 years, 6 months ago by m.m.capewell
Modified:
6 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Avoid duplicate vmla when merging vmul and vadd Avoid generating duplicate vmla instructions for vmul/vadd sequences where the vmul has more than one use. For example: function f(a, b, c) { return (a * b) + c + (a * b); } Previously, this would produce a vmul for the subexpression (a * b), then vmla for (a * b) + c, then vmla for (a * b) + [(a * b) + c]. Now it produces vmul, vadd, vadd, as expected. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M src/arm/lithium-arm.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
m.m.capewell
6 years, 6 months ago (2014-06-11 16:39:17 UTC) #1
ulan
6 years, 6 months ago (2014-06-16 11:14:47 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698