Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Issue 323423002: DevTools: Deleting object property in console would just assign it to undefined. (Closed)

Created:
6 years, 6 months ago by aandrey
Modified:
6 years, 6 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Deleting object property in console would just assign it to undefined. Evaluate explicit "delete this[p]" to delete a property. R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -26 lines) Patch
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 6 chunks +22 lines, -16 lines 0 comments Download
M Source/devtools/front_end/sdk/RemoteObject.js View 2 chunks +41 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 2 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
aandrey
6 years, 6 months ago (2014-06-11 16:12:59 UTC) #1
vsevik
lgtm
6 years, 6 months ago (2014-06-13 06:38:15 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-16 05:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/323423002/1
6 years, 6 months ago (2014-06-16 05:50:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 07:48:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12051)
6 years, 6 months ago (2014-06-16 07:48:33 UTC) #6
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-16 07:59:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/323423002/1
6 years, 6 months ago (2014-06-16 07:59:15 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 08:43:42 UTC) #9
Message was sent while issue was closed.
Change committed as 176188

Powered by Google App Engine
This is Rietveld 408576698