Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 323413003: Makes the view manager notify the client of new roots correctly (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Makes the view manager notify the client of new roots correctly Prior to this patch the server would not notify the client of a new root if the client already knew about the root. Now it always notifies. Here's an example of this case: two nodes, A and B with B a child of A and A the root for the client. If B is added as a root then previously I would not send B in OnRootsAdded. Now I do. BUG=365012 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M mojo/services/view_manager/view_manager_connection.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sky
6 years, 6 months ago (2014-06-11 16:36:40 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-06-11 16:41:54 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-11 16:50:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/323413003/1
6 years, 6 months ago (2014-06-11 16:52:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 20:43:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:18:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26099)
6 years, 6 months ago (2014-06-11 21:18:44 UTC) #7
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-12 17:19:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/323413003/1
6 years, 6 months ago (2014-06-12 17:23:26 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 21:11:57 UTC) #10
Message was sent while issue was closed.
Change committed as 276803

Powered by Google App Engine
This is Rietveld 408576698