Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 323403007: [Android] Java Bridge with Gin: implement Java bound object (Closed)

Created:
6 years, 6 months ago by mnaganov (inactive)
Modified:
6 years, 6 months ago
Reviewers:
Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam, benm (inactive)
Project:
chromium
Visibility:
Public.

Description

[Android] Java Bridge with Gin: implement Java bound object This patch adds implementation for GinJavaBoundObject class, which is responsible for interacting with injected Java objects, and a helper trivial class GinJavaBoundObjectDelegate which is used with GinJavaMethodInvocationHelper Java interaction code is mostly taken from the existing implementation. The main difference that the new implementation has, is that the relationship between Java objects and JavaScript interface objects is now managed by us, not by NPAPI. This patch also contains the following fixes to the existing code discovered after re-running tests: -- ART doesn't like when static Java methods are invoked using JNI calls for instance methods, so switched to use the right JNI calls; -- accessing 'window' object when adding JavaScript interface objects may cause DidClearWindowObject to be called, so guard against double entrance. BUG=355644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278214

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 8 (0 generated)
mnaganov (inactive)
Hi Torne, The next chunk of Gin Java bridge. I think, it's simpler than the ...
6 years, 6 months ago (2014-06-12 15:09:34 UTC) #1
mnaganov (inactive)
6 years, 6 months ago (2014-06-12 15:29:58 UTC) #2
mnaganov (inactive)
Ping?
6 years, 6 months ago (2014-06-18 14:56:14 UTC) #3
Torne
LGTM. This still isn't actually hooked up to anything, right?
6 years, 6 months ago (2014-06-18 16:24:56 UTC) #4
mnaganov (inactive)
On 2014/06/18 16:24:56, Torne wrote: > LGTM. This still isn't actually hooked up to anything, ...
6 years, 6 months ago (2014-06-18 16:41:18 UTC) #5
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 6 months ago (2014-06-18 16:57:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/323403007/20001
6 years, 6 months ago (2014-06-18 16:58:14 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 01:10:25 UTC) #8
Message was sent while issue was closed.
Change committed as 278214

Powered by Google App Engine
This is Rietveld 408576698