Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323403002: Re-land RenderTextHarfBuzz: Decide run direction by BiDi embedding level (Closed)

Created:
6 years, 6 months ago by ckocagil
Modified:
6 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, Alexei Svitkine (slow)
Visibility:
Public.

Description

Re-land RenderTextHarfBuzz: Decide run direction by BiDi embedding level Original CL: https://codereview.chromium.org/326123003/ BUG=382178 NOTRY=true R=msw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276525

Patch Set 1 : original #

Patch Set 2 : annotate intentional leaks #

Total comments: 1

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -42 lines) Patch
M ui/gfx/render_text_harfbuzz.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 1 2 6 chunks +43 lines, -41 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ckocagil
6 years, 6 months ago (2014-06-11 17:05:30 UTC) #1
msw
lgtm, +CC Alexei for FYI https://codereview.chromium.org/323403002/diff/50001/ui/gfx/render_text_harfbuzz.cc File ui/gfx/render_text_harfbuzz.cc (right): https://codereview.chromium.org/323403002/diff/50001/ui/gfx/render_text_harfbuzz.cc#newcode258 ui/gfx/render_text_harfbuzz.cc:258: // HarfBuzz faces created ...
6 years, 6 months ago (2014-06-11 17:18:00 UTC) #2
ckocagil
The CQ bit was checked by ckocagil@chromium.org
6 years, 6 months ago (2014-06-11 18:24:17 UTC) #3
ckocagil
The CQ bit was unchecked by ckocagil@chromium.org
6 years, 6 months ago (2014-06-11 18:24:23 UTC) #4
ckocagil
The CQ bit was checked by ckocagil@chromium.org
6 years, 6 months ago (2014-06-11 18:26:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/323403002/70001
6 years, 6 months ago (2014-06-11 18:29:01 UTC) #6
ckocagil
The CQ bit was unchecked by ckocagil@chromium.org
6 years, 6 months ago (2014-06-11 20:19:45 UTC) #7
ckocagil
The CQ bit was checked by ckocagil@chromium.org
6 years, 6 months ago (2014-06-11 20:19:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/323403002/70001
6 years, 6 months ago (2014-06-11 20:20:23 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 04:03:44 UTC) #10
Message was sent while issue was closed. 
Change committed as 276525

Powered by Google App Engine
This is Rietveld 408576698