Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3851)

Unified Diff: chrome/test/chromedriver/test/run_all_tests.py

Issue 323383004: [chromedriver] Fix waiting and downloading snapshot builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nit. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/run_buildbot_steps.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_all_tests.py
diff --git a/chrome/test/chromedriver/test/run_all_tests.py b/chrome/test/chromedriver/test/run_all_tests.py
index 9f303f5a9f3928d52490eb625486c58fefffc660..63eedd17ff811f4ee2a4ebed7375a18393c2d39c 100755
--- a/chrome/test/chromedriver/test/run_all_tests.py
+++ b/chrome/test/chromedriver/test/run_all_tests.py
@@ -188,14 +188,9 @@ def main():
code = code or code1 or code2
return code
else:
- latest_download_site = archive.Site.BLINK_SNAPSHOT
- if util.IsLinux() and platform.architecture()[0] == '32bit':
- # There is no linux32 blink build, so use a build from the chromium
- # snapshot build archive instead.
- latest_download_site = archive.Site.CHROMIUM_SNAPSHOT
- latest_snapshot = archive.GetLatestRevision(latest_download_site)
+ latest_snapshot_revision = archive.GetLatestSnapshotVersion()
versions = [
- ['HEAD', latest_snapshot],
+ ['HEAD', latest_snapshot_revision],
['36', archive.CHROME_36_REVISION],
['35', archive.CHROME_35_REVISION],
['34', archive.CHROME_34_REVISION]
@@ -208,7 +203,7 @@ def main():
version_name = version[0]
if version_name == 'HEAD':
version_name = version[1]
- download_site = latest_download_site
+ download_site = archive.GetSnapshotDownloadSite()
temp_dir, chrome_path = DownloadChrome(version_name, version[1],
download_site)
if not chrome_path:
« no previous file with comments | « chrome/test/chromedriver/run_buildbot_steps.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698