Issue 323373002: Narrowed expectation margins noticeably

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 323373002: Narrowed expectation margins noticeably (Closed)

Created:
6 years, 6 months ago by kelvinly

Modified:
6 years, 6 months ago

Reviewers:
jcgregorio, bsalomon, benchen, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bench/gen_bench_expectations.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

kelvinly

More formula changes. I'll try to do some proper statistical analysis on the perf data ...

6 years, 6 months ago (2014-06-11 14:23:06 UTC) #1

benchen

lgtm yes, there could be outliers, for instance maybe the first iteration number is usually ...

6 years, 6 months ago (2014-06-11 14:38:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/323373002/20001

6 years, 6 months ago (2014-06-11 15:05:09 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-11 15:05:16 UTC) #5

Message was sent while issue was closed.

Change committed as 1acb8df76dd915f4f48dd0b9618a4ec1478f72a4