Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: Source/devtools/front_end/sdk/RemoteObject.js

Issue 323313005: DevTools: Dont allow editing internal object properties in console. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 347
348 result.push(remoteProperty); 348 result.push(remoteProperty);
349 } 349 }
350 var internalPropertiesResult = null; 350 var internalPropertiesResult = null;
351 if (internalProperties) { 351 if (internalProperties) {
352 internalPropertiesResult = []; 352 internalPropertiesResult = [];
353 for (var i = 0; i < internalProperties.length; i++) { 353 for (var i = 0; i < internalProperties.length; i++) {
354 var property = internalProperties[i]; 354 var property = internalProperties[i];
355 if (!property.value) 355 if (!property.value)
356 continue; 356 continue;
357 internalPropertiesResult.push(new WebInspector.RemoteObjectP roperty(property.name, this._target.runtimeModel.createRemoteObject(property.val ue))); 357 var propertyValue = this._target.runtimeModel.createRemoteOb ject(property.value);
358 internalPropertiesResult.push(new WebInspector.RemoteObjectP roperty(property.name, propertyValue, true, false));
358 } 359 }
359 } 360 }
360 callback(result, internalPropertiesResult); 361 callback(result, internalPropertiesResult);
361 } 362 }
362 this._runtimeAgent.getProperties(this._objectId, ownProperties, accessor PropertiesOnly, remoteObjectBinder.bind(this)); 363 this._runtimeAgent.getProperties(this._objectId, ownProperties, accessor PropertiesOnly, remoteObjectBinder.bind(this));
363 }, 364 },
364 365
365 /** 366 /**
366 * @param {string} name 367 * @param {string} name
367 * @param {string} value 368 * @param {string} value
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
966 result = functionDeclaration.apply(target, rawArgs); 967 result = functionDeclaration.apply(target, rawArgs);
967 } catch (e) { 968 } catch (e) {
968 result = null; 969 result = null;
969 } 970 }
970 971
971 callback(result); 972 callback(result);
972 }, 973 },
973 974
974 __proto__: WebInspector.RemoteObject.prototype 975 __proto__: WebInspector.RemoteObject.prototype
975 } 976 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698