Issue 323293004: Enable Oilpan for ImageBitmapFactories::ImageBitmapLoader by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 323293004: Enable Oilpan for ImageBitmapFactories::ImageBitmapLoader by default. (Closed)

Created:
6 years, 6 months ago by tkent

Modified:
6 years, 6 months ago

Reviewers:
oilpan-reviews, haraken, Stephen White, Justin Novosad

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Enable Oilpan for ImageBitmapFactories::ImageBitmapLoader by default. We can't enable Oilpan for ImageBitmapFactories, another class in modules/imagebitmap/, because it's a Supplement of DOMWindow or WorkerGlobalScope. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176252

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	Source/modules/imagebitmap/ImageBitmapFactories.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	Source/modules/imagebitmap/ImageBitmapFactories.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM in terms of oilpan. Let's wait for an approval of imagebitmap/ owners.

6 years, 6 months ago (2014-06-11 07:09:37 UTC) #2

Justin Novosad

On 2014/06/11 07:09:37, haraken wrote: > LGTM in terms of oilpan. Let's wait for an ...

6 years, 6 months ago (2014-06-16 19:46:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/323293004/1

6 years, 6 months ago (2014-06-16 22:47:47 UTC) #5

Message was sent while issue was closed.

Change committed as 176252

Expand Messages | Collapse Messages