Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 323293002: Fix fast/css tests for Win7/DirectWrite by explicitly setting height (Closed)

Created:
6 years, 6 months ago by eae
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
blink-reviews
Visibility:
Public.

Description

Fix fast/css tests for Win7/DirectWrite by explicitly setting height The height of text and form control can vary slightly depending on alignment and baseline. Explicitly set height for CSS tests that do not test nor depend on text rendering. BUG=378610 R=dglazkov@chromium.org, eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/font-face-unicode-range.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/font-face-unicode-range-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css/negative-text-indent-in-inline-block.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
eae
6 years, 6 months ago (2014-06-11 02:22:31 UTC) #1
eae
6 years, 6 months ago (2014-06-11 02:22:57 UTC) #2
eae
6 years, 6 months ago (2014-06-12 02:18:51 UTC) #3
eae
6 years, 6 months ago (2014-06-12 02:19:11 UTC) #4
eae
6 years, 6 months ago (2014-06-12 15:17:26 UTC) #5
dglazkov
lgtm
6 years, 6 months ago (2014-06-12 15:18:40 UTC) #6
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-06-12 15:25:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/323293002/1
6 years, 6 months ago (2014-06-12 15:25:56 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-12 15:29:32 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 15:32:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7534)
6 years, 6 months ago (2014-06-12 15:32:13 UTC) #11
eae
6 years, 6 months ago (2014-06-12 16:40:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 manually as r176035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698