Issue 323283002: switch to colortype for deepcopy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 323283002: switch to colortype for deepcopy (Closed)

Created:
6 years, 6 months ago by reed2

Modified:
6 years, 6 months ago

Reviewers:
bsalomon, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

switch to colortype for deepcopy BUG=skia: Committed: https://skia.googlesource.com/skia/+/e4538f5b46d70798e34eb078f5d5e76a59d02318

Patch Set 2 : #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -21 lines)			Patch
M	include/core/SkPixelRef.h	View		1 chunk	+2 lines, -2 lines	1 comment	Download
M	include/gpu/SkGrPixelRef.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBitmap.cpp	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	src/gpu/SkGrPixelRef.cpp	View		4 chunks	+7 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + a nit https://codereview.chromium.org/323283002/diff/20001/include/core/SkPixelRef.h File include/core/SkPixelRef.h (right): https://codereview.chromium.org/323283002/diff/20001/include/core/SkPixelRef.h#newcode225 include/core/SkPixelRef.h:225: * Makes a deep copy ...

6 years, 6 months ago (2014-06-11 12:31:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/323283002/20001

6 years, 6 months ago (2014-06-11 12:54:39 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-11 13:09:56 UTC) #5

Message was sent while issue was closed.

Change committed as e4538f5b46d70798e34eb078f5d5e76a59d02318

Expand Messages | Collapse Messages

Issue 323283002: switch to colortype for deepcopy (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages