Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323253002: Remove NodeRemovalDispatcher (Closed)

Created:
6 years, 6 months ago by esprehn
Modified:
6 years, 6 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Visibility:
Public.

Description

Remove NodeRemovalDispatcher Since we don't have the SVGInstance tree anymore we can get rid of this template dispatcher. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -29 lines) Patch
M Source/core/dom/ContainerNodeAlgorithms.h View 2 chunks +3 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
esprehn
6 years, 6 months ago (2014-06-11 17:01:20 UTC) #1
ojan
lgtm
6 years, 6 months ago (2014-06-11 17:45:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/323253002/1
6 years, 6 months ago (2014-06-11 17:45:38 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-11 18:11:48 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 18:12:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16003)
6 years, 6 months ago (2014-06-11 18:12:01 UTC) #6
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 6 months ago (2014-06-11 18:15:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/323253002/1
6 years, 6 months ago (2014-06-11 18:16:53 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-11 18:17:15 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 18:17:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16003)
6 years, 6 months ago (2014-06-11 18:17:27 UTC) #11
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 6 months ago (2014-06-11 22:18:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/323253002/1
6 years, 6 months ago (2014-06-11 22:19:03 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 05:27:02 UTC) #14
Message was sent while issue was closed. 
Change committed as 175984

Powered by Google App Engine
This is Rietveld 408576698