Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 32323012: IDL compiler: move EventHandler null check out of generated bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | Source/bindings/v8/V8EventListenerList.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index a4b0c0049cf641624abfebcbd0302fc23fd5aa7c..37e4144f6364ebfb1d2702be790cf53630593049 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -1955,9 +1955,6 @@ END
if ($attribute->type eq "EventHandler") {
my $implSetterFunctionName = FirstLetterToUpperCase($attrName);
- # Non callable input should be treated as null
- $code .= " if (!jsValue->IsNull() && !jsValue->IsFunction())\n";
- $code .= " jsValue = v8::Null(info.GetIsolate());\n";
if (!InheritsInterface($interface, "Node")) {
my $attrImplName = GetImplName($attribute);
$code .= " transferHiddenDependency(info.Holder(), imp->${attrImplName}(isolatedWorldForIsolate(info.GetIsolate())), jsValue, ${v8ClassName}::eventListenerCacheIndex, info.GetIsolate());\n";
« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | Source/bindings/v8/V8EventListenerList.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698