Chromium Code Reviews| Index: Source/bindings/v8/V8Utilities.cpp |
| diff --git a/Source/bindings/v8/V8Utilities.cpp b/Source/bindings/v8/V8Utilities.cpp |
| index 7d4e64becdf738f6e2ed32f9598ea4f023cbc46a..71d7493b164bbc2aeb7128e7b8b2535ecaa7da6e 100644 |
| --- a/Source/bindings/v8/V8Utilities.cpp |
| +++ b/Source/bindings/v8/V8Utilities.cpp |
| @@ -149,6 +149,9 @@ void transferHiddenDependency(v8::Handle<v8::Object> object, EventListener* oldV |
| removeHiddenDependency(object, oldListenerObject, cacheIndex, isolate); |
| } |
| } |
| + // Non-callable input should be treated as null |
| + if (!newValue->IsNull() && !newValue->IsFunction()) |
|
Nils Barth (inactive)
2013/10/22 01:46:38
We can merge these checks, right?
As:
if (!newValu
haraken
2013/10/22 02:05:14
Right.
|
| + newValue = v8::Null(isolate); |
| if (!newValue->IsNull() && !newValue->IsUndefined()) |
| createHiddenDependency(object, newValue, cacheIndex, isolate); |
| } |