Source/bindings/templates/attributes.cpp - Issue 32323012: IDL compiler: move EventHandler null check out of generated bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 32323012: IDL compiler: move EventHandler null check out of generated bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | Source/bindings/v8/V8EventListenerList.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index a603d35792fff0333c88d81bbfc0b251c6c0e397..8819a388600df19d69ad7cae65d8855143f87aea 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -125,9 +125,6 @@ static void {{attribute.name}}AttributeSetter{{world_suffix}}(v8::Local<v8::Stri

{% if attribute.idl_type != 'EventHandler' %}

{{attribute.v8_value_to_local_cpp_value}};

{% else %}{# EventHandler hack #}

- {# Non-callable input should be treated as null #}

- if (!jsValue->IsNull() && !jsValue->IsFunction())

- jsValue = v8::Null(info.GetIsolate());

transferHiddenDependency(info.Holder(), {{attribute.event_handler_getter_expression}}, jsValue, {{v8_class_name}}::eventListenerCacheIndex, info.GetIsolate());

{% endif %}

{% if attribute.enum_validation_expression %}

« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | Source/bindings/v8/V8EventListenerList.h » ('J')