Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: Source/bindings/v8/V8EventListenerList.cpp

Issue 32323012: IDL compiler: move EventHandler null check out of generated bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 24 matching lines...) Expand all
35 #include "bindings/v8/V8Binding.h" 35 #include "bindings/v8/V8Binding.h"
36 #include "bindings/v8/V8WorkerGlobalScopeEventListener.h" 36 #include "bindings/v8/V8WorkerGlobalScopeEventListener.h"
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 PassRefPtr<EventListener> V8EventListenerList::getEventListener(v8::Local<v8::Va lue> value, bool isAttribute, ListenerLookupType lookup) 40 PassRefPtr<EventListener> V8EventListenerList::getEventListener(v8::Local<v8::Va lue> value, bool isAttribute, ListenerLookupType lookup)
41 { 41 {
42 v8::Handle<v8::Context> context = v8::Context::GetCurrent(); 42 v8::Handle<v8::Context> context = v8::Context::GetCurrent();
43 if (context.IsEmpty()) 43 if (context.IsEmpty())
44 return 0; 44 return 0;
45 v8::Isolate* isolate = context->GetIsolate();
Nils Barth (inactive) 2013/10/22 01:46:38 We should actually just pass an isolate in here, A
45 if (lookup == ListenerFindOnly) 46 if (lookup == ListenerFindOnly)
46 return V8EventListenerList::findWrapper(value, isAttribute, context->Get Isolate()); 47 return V8EventListenerList::findWrapper(value, isAttribute, isolate);
47 if (V8DOMWrapper::isWrapperOfType(toInnerGlobalObject(context), &V8Window::i nfo)) 48 if (V8DOMWrapper::isWrapperOfType(toInnerGlobalObject(context), &V8Window::i nfo))
48 return V8EventListenerList::findOrCreateWrapper<V8EventListener>(value, isAttribute, context->GetIsolate()); 49 return V8EventListenerList::findOrCreateWrapper<V8EventListener>(value, isAttribute, isolate);
49 return V8EventListenerList::findOrCreateWrapper<V8WorkerGlobalScopeEventList ener>(value, isAttribute, context->GetIsolate()); 50 return V8EventListenerList::findOrCreateWrapper<V8WorkerGlobalScopeEventList ener>(value, isAttribute, isolate);
50 } 51 }
51 52
52 } // namespace WebCore 53 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698