Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 32323009: mesa compile fixes for VS2013 (Closed)

Created:
7 years, 2 months ago by scottmg
Modified:
7 years, 2 months ago
Reviewers:
marcheu
CC:
chromium-reviews
Visibility:
Public.

Description

mesa compile fixes for VS2013 - _Bool is defined in standard headers now - fpclassify is in the standard library R=marcheu@chromium.org BUG=288948

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M include/c99/stdbool.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mesa/main/querymatrix.c View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
7 years, 2 months ago (2013-10-21 23:02:21 UTC) #1
marcheu
This looks sounds, we should probably upstream it as well. https://codereview.chromium.org/32323009/diff/1/src/mesa/main/querymatrix.c File src/mesa/main/querymatrix.c (right): https://codereview.chromium.org/32323009/diff/1/src/mesa/main/querymatrix.c#newcode40 ...
7 years, 2 months ago (2013-10-21 23:20:17 UTC) #2
scottmg
OK, I'll see if I can figure out how to contribute patches upstream. https://codereview.chromium.org/32323009/diff/1/src/mesa/main/querymatrix.c File ...
7 years, 2 months ago (2013-10-21 23:23:23 UTC) #3
scottmg
On 2013/10/21 23:23:23, scottmg wrote: > OK, I'll see if I can figure out how ...
7 years, 2 months ago (2013-10-21 23:44:11 UTC) #4
marcheu
LGTM Thanks for filing upstream!
7 years, 2 months ago (2013-10-22 00:42:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/32323009/90001
7 years, 2 months ago (2013-10-22 01:09:12 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 01:09:23 UTC) #7
Message was sent while issue was closed.
Change committed as 229994

Powered by Google App Engine
This is Rietveld 408576698