Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 323163004: [NaCl SDK] docs: Introduce .bc vs .pexe naming convention before using that in doc. (Closed)

Created:
6 years, 6 months ago by jvoung (off chromium)
Modified:
6 years, 6 months ago
Reviewers:
binji, JF, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] docs: Introduce .bc vs .pexe naming convention before using that in doc. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M native_client_sdk/doc_generated/devguide/devcycle/debugging.html View 1 chunk +4 lines, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/debugging.rst View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jvoung (off chromium)
6 years, 6 months ago (2014-06-10 20:03:03 UTC) #1
Sam Clegg
Can you start the description with '[NaCl SDK] docs:'? My eyes are hardcoded for the ...
6 years, 6 months ago (2014-06-10 20:18:39 UTC) #2
jvoung (off chromium)
On 2014/06/10 20:18:39, Sam Clegg wrote: > Can you start the description with '[NaCl SDK] ...
6 years, 6 months ago (2014-06-10 20:47:31 UTC) #3
Sam Clegg
lgtm
6 years, 6 months ago (2014-06-11 00:11:51 UTC) #4
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 6 months ago (2014-06-11 15:37:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/323163004/1
6 years, 6 months ago (2014-06-11 15:41:36 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 15:44:05 UTC) #7
Message was sent while issue was closed.
Change committed as 276413

Powered by Google App Engine
This is Rietveld 408576698