Enable building and output-ing of browser_tests.exe for official Windows builds.

Enable building and output-ing of browser_tests.exe for official Windows builds.

BUG=379986
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276388

[anandc, 2014-06-10 19:32:47]

PTAL. With browser_tests.exe now successfully building on Windows with VS2013,
this should work. Thanks.

[gab, 2014-06-10 21:09:11]

Please don't add all OWNERS to a change unless you truly need everybody's review
(which I very doubt you do here). This is disrespectful of the time of reviewers
(who may review in parallel unnecessarily).

In this case, as stated by the OWNERS file @
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/tools/build...
:
the owners of FILES.cfg are mmoss and kerz.

build/ is owned by all so you don't need a specific owner there.

Leaving mmoss as reviewer and moving everybody else to CC. Please be careful
with adding only the reviewers you need and stating what everybody's expected to
review in the future.

Thanks,
Gab

[Michael Moss, 2014-06-10 21:37:45]

https://codereview.chromium.org/323163003/diff/1/chrome/tools/build/win/FILES...
File chrome/tools/build/win/FILES.cfg (right):

https://codereview.chromium.org/323163003/diff/1/chrome/tools/build/win/FILES...
chrome/tools/build/win/FILES.cfg:35: 'filegroup': ['default', 'symsrc'],
Probably don't want 'symsrc' here, since it seems unlikely we care about serving
symbols for test executables.

https://codereview.chromium.org/323163003/diff/1/chrome/tools/build/win/FILES...
chrome/tools/build/win/FILES.cfg:36: 'archive':  'browser_tests.exe',
I believe 'filegroup [default]' and 'archive' are mutually exclusive.

[anandc, 2014-06-11 00:44:56]

Thanks. PTAL. Also removed 'dev' from buildtype, because this has only been
enabled for Official builds in this CL. 

I could enable for dev-builds too, just let me know what the target should be in
all.gyp.

https://codereview.chromium.org/323163003/diff/1/chrome/tools/build/win/FILES...
File chrome/tools/build/win/FILES.cfg (right):

https://codereview.chromium.org/323163003/diff/1/chrome/tools/build/win/FILES...
chrome/tools/build/win/FILES.cfg:35: 'filegroup': ['default', 'symsrc'],
On 2014/06/10 21:37:45, Michael Moss wrote:
> Probably don't want 'symsrc' here, since it seems unlikely we care about
serving
> symbols for test executables.

Done.

https://codereview.chromium.org/323163003/diff/1/chrome/tools/build/win/FILES...
chrome/tools/build/win/FILES.cfg:36: 'archive':  'browser_tests.exe',
On 2014/06/10 21:37:45, Michael Moss wrote:
> I believe 'filegroup [default]' and 'archive' are mutually exclusive.

Done.

[Michael Moss, 2014-06-11 01:13:09]

https://codereview.chromium.org/323163003/diff/20001/chrome/tools/build/win/F...
File chrome/tools/build/win/FILES.cfg (right):

https://codereview.chromium.org/323163003/diff/20001/chrome/tools/build/win/F...
chrome/tools/build/win/FILES.cfg:37: FILES = [
Your change has to go inside the FILES[] block.

[anandc, 2014-06-11 01:43:13]

Fixed. PTAL. Thanks.

https://codereview.chromium.org/323163003/diff/20001/chrome/tools/build/win/F...
File chrome/tools/build/win/FILES.cfg (right):

https://codereview.chromium.org/323163003/diff/20001/chrome/tools/build/win/F...
chrome/tools/build/win/FILES.cfg:37: FILES = [
On 2014/06/11 01:13:09, Michael Moss wrote:
> Your change has to go inside the FILES[] block.

Done.

[Michael Moss, 2014-06-11 03:10:09]

lgtm

[anandc, 2014-06-11 03:36:02]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-06-11 03:40:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/anandc@chromium.org/323163003/60001

[commit-bot: I haz the power, 2014-06-11 09:44:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-06-11 09:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 09:49:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[anandc, 2014-06-11 13:58:50]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-06-11 13:59:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/anandc@chromium.org/323163003/60001

[commit-bot: I haz the power, 2014-06-11 14:29:17]

Change committed as 276388