runtime/vm/dart_api_message.cc - Issue 323163002: Adds an assertion to limit snapshot intptr_t size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_message.cc

Issue 323163002: Adds an assertion to limit snapshot intptr_t size. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_message.cc

===================================================================

--- runtime/vm/dart_api_message.cc (revision 37116)

+++ runtime/vm/dart_api_message.cc (working copy)

@@ -1154,9 +1154,9 @@

Dart_WeakPersistentHandleFinalizer callback =

object->value.as_external_typed_data.callback;

WriteSmi(length);

- WriteIntptrValue(reinterpret_cast<intptr_t>(data));

- WriteIntptrValue(reinterpret_cast<intptr_t>(peer));

- WriteIntptrValue(reinterpret_cast<intptr_t>(callback));

+ WriteRawPointerValue(reinterpret_cast<intptr_t>(data));

+ WriteRawPointerValue(reinterpret_cast<intptr_t>(peer));

+ WriteRawPointerValue(reinterpret_cast<intptr_t>(callback));

siva 2014/06/10 19:51:37 Would be symmetric to also add a ReadRawPointerVal

zra 2014/06/10 20:15:37 Done.

break;

}

default:

« no previous file with comments | « no previous file | runtime/vm/snapshot.h » ('j') | no next file with comments »