Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 323133002: Remove --sync-invalidate-xmpp-login and --sync-try-ssltcp-first-for-xmpp. (Closed)

Created:
6 years, 6 months ago by pavely
Modified:
6 years, 6 months ago
Reviewers:
rlarocque
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove --sync-invalidate-xmpp-login and --sync-try-ssltcp-first-for-xmpp. They are not used in test or for troubleshooting. BUG=382976 R=rlarocque@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M components/invalidation/invalidation_service_util.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M components/invalidation/invalidation_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/invalidation/invalidation_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pavely
6 years, 6 months ago (2014-06-10 17:59:31 UTC) #1
rlarocque
lgtm lgtm
6 years, 6 months ago (2014-06-10 18:08:38 UTC) #2
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 6 months ago (2014-06-10 18:16:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/323133002/1
6 years, 6 months ago (2014-06-10 18:18:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 02:53:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 08:56:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/18848)
6 years, 6 months ago (2014-06-11 08:56:12 UTC) #7
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 6 months ago (2014-06-11 17:36:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/323133002/1
6 years, 6 months ago (2014-06-11 17:39:12 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 17:42:36 UTC) #10
Message was sent while issue was closed.
Change committed as 276442

Powered by Google App Engine
This is Rietveld 408576698