Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 323103002: Temporarily disable uint32 mode for comparisons (Closed)

Created:
6 years, 6 months ago by Jakob Kummerow
Modified:
6 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Sven Panne
Visibility:
Public.

Description

Temporarily disable uint32 mode for comparisons BUG=v8:3380 LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/hydrogen-uint32-analysis.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
This effectively reverts r21355 (where a plain revert wouldn't apply cleanly).
6 years, 6 months ago (2014-06-10 14:37:06 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
6 years, 6 months ago (2014-06-10 15:29:52 UTC) #2
Jakob Kummerow
6 years, 6 months ago (2014-06-10 18:54:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698