Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 323083002: [WebMIDI] Fix a WebMIDIPermissionRequest leak. (Closed)

Created:
6 years, 6 months ago by yhirano
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, wjia+watch_chromium.org, mcasas+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

[WebMIDI] Fix a WebMIDIPermissionRequest leak. IDMap<T, OS> owns its values only if OS == IDMapOwnPtr. BUG=NONE R=toyoshim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276614

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M content/renderer/media/midi_dispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/midi_dispatcher.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yhirano
6 years, 6 months ago (2014-06-10 13:01:45 UTC) #1
Takashi Toyoshima
lgtm. thank you for catching this.
6 years, 6 months ago (2014-06-11 04:24:56 UTC) #2
yhirano
+dalecurtis for OWNER review.
6 years, 6 months ago (2014-06-11 04:50:18 UTC) #3
DaleCurtis
lgtm
6 years, 6 months ago (2014-06-11 21:22:23 UTC) #4
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 6 months ago (2014-06-11 23:56:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/323083002/20001
6 years, 6 months ago (2014-06-11 23:57:10 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 04:47:19 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 10:13:32 UTC) #8
Message was sent while issue was closed.
Change committed as 276614

Powered by Google App Engine
This is Rietveld 408576698