Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 323063002: DevTools: NetworkPanel: fix "status" column rendering. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 2455 matching lines...) Expand 10 before | Expand all | Expand 10 after
2466 * @param {string} columnIdentifier 2466 * @param {string} columnIdentifier
2467 * @return {!Element} 2467 * @return {!Element}
2468 */ 2468 */
2469 createCell: function(columnIdentifier) 2469 createCell: function(columnIdentifier)
2470 { 2470 {
2471 var cell = this.createTD(columnIdentifier); 2471 var cell = this.createTD(columnIdentifier);
2472 switch (columnIdentifier) { 2472 switch (columnIdentifier) {
2473 case "name": this._renderNameCell(cell); break; 2473 case "name": this._renderNameCell(cell); break;
2474 case "timeline": this._createTimelineBar(cell); break; 2474 case "timeline": this._createTimelineBar(cell); break;
2475 case "method": cell.setTextAndTitle(this._request.requestMethod); break; 2475 case "method": cell.setTextAndTitle(this._request.requestMethod); break;
2476 case "status": this._renderStatusCell(cell); break;
2476 case "scheme": cell.setTextAndTitle(this._request.scheme); break; 2477 case "scheme": cell.setTextAndTitle(this._request.scheme); break;
2477 case "domain": cell.setTextAndTitle(this._request.domain); break; 2478 case "domain": cell.setTextAndTitle(this._request.domain); break;
2478 case "remoteAddress": cell.setTextAndTitle(this._request.remoteAddress() ); break; 2479 case "remoteAddress": cell.setTextAndTitle(this._request.remoteAddress() ); break;
2479 case "cookies": cell.setTextAndTitle(this._arrayLength(this._request.req uestCookies)); break; 2480 case "cookies": cell.setTextAndTitle(this._arrayLength(this._request.req uestCookies)); break;
2480 case "setCookies": cell.setTextAndTitle(this._arrayLength(this._request. responseCookies)); break; 2481 case "setCookies": cell.setTextAndTitle(this._arrayLength(this._request. responseCookies)); break;
2481 case "type": this._renderTypeCell(cell); break; 2482 case "type": this._renderTypeCell(cell); break;
2482 case "initiator": this._renderInitiatorCell(cell); break; 2483 case "initiator": this._renderInitiatorCell(cell); break;
2483 case "size": this._renderSizeCell(cell); break; 2484 case "size": this._renderSizeCell(cell); break;
2484 case "time": this._renderTimeCell(cell); break; 2485 case "time": this._renderTimeCell(cell); break;
2485 default: cell.setTextAndTitle(this._request.responseHeaderValue(columnId entifier) || ""); break; 2486 default: cell.setTextAndTitle(this._request.responseHeaderValue(columnId entifier) || ""); break;
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
2919 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b) 2920 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b)
2920 { 2921 {
2921 var aValue = a._request[propertyName]; 2922 var aValue = a._request[propertyName];
2922 var bValue = b._request[propertyName]; 2923 var bValue = b._request[propertyName];
2923 if (aValue > bValue) 2924 if (aValue > bValue)
2924 return revert ? -1 : 1; 2925 return revert ? -1 : 1;
2925 if (bValue > aValue) 2926 if (bValue > aValue)
2926 return revert ? 1 : -1; 2927 return revert ? 1 : -1;
2927 return 0; 2928 return 0;
2928 } 2929 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698