Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 323043005: Partial revert of r174548: Make several functions in SVGRenderSupport templated for performance (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink
Visibility:
Public.

Description

Partial revert of r174548: Make several functions in SVGRenderSupport templated for performance Partial revert of r174548: Make several functions in SVGRenderSupport templated for performance. This is an speculative attempt to fix a crash in WebCore::SVGRenderSupport::computeContainerBoundingBoxes<WebCore::RenderSVGRoot>(). R=pdr@chromium.org BUG=382428 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175955

Patch Set 1 #

Patch Set 2 : Build fix #

Patch Set 3 : win build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -143 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceMarker.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGViewportContainer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 1 3 chunks +6 lines, -143 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 5 chunks +135 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 6 months ago (2014-06-10 17:11:30 UTC) #1
pdr.
LGTM, thanks for giving this a shot.
6 years, 6 months ago (2014-06-11 03:16:30 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-11 03:16:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/323043005/20001
6 years, 6 months ago (2014-06-11 03:17:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-11 04:47:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 06:11:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11547)
6 years, 6 months ago (2014-06-11 06:11:08 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-11 11:33:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/323043005/40001
6 years, 6 months ago (2014-06-11 11:34:13 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 12:36:04 UTC) #10
Message was sent while issue was closed.
Change committed as 175955

Powered by Google App Engine
This is Rietveld 408576698