Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 323043004: Make NOTIFICATION_HISTORY_URLS_MODIFIED fired consistently for both typed and non-typed URLs (Closed)

Created:
6 years, 6 months ago by engedy
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Make NOTIFICATION_HISTORY_URLS_MODIFIED fired consistently for both typed and non-typed URLs. The semantics for NOTIFICATION_HISTORY_URLS_MODIFIED was changed as of revision 131865 (https://chromiumcodereview.appspot.com/9852002) so that it would be fired not only for typed URLs, but also for non-typed ones (that is, URLs having |typed_count| == 0). However, HistoryBackend::AddPagesWithDetails() was not updated to reflect these new semantics. Rectify this omission to make the code less mysterious. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M chrome/browser/history/history_backend.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
engedy
@Brett: Please take a look. The new implementation is in line with the existing semantics ...
6 years, 6 months ago (2014-06-10 17:56:20 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-11 21:58:41 UTC) #2
engedy
The CQ bit was checked by engedy@chromium.org
6 years, 6 months ago (2014-06-11 22:01:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/engedy@chromium.org/323043004/1
6 years, 6 months ago (2014-06-11 22:04:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:52:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:54:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/31513) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26371) win_gpu ...
6 years, 6 months ago (2014-06-12 00:54:35 UTC) #7
engedy
The CQ bit was checked by engedy@chromium.org
6 years, 6 months ago (2014-06-12 07:27:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/engedy@chromium.org/323043004/1
6 years, 6 months ago (2014-06-12 07:31:51 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 11:02:45 UTC) #10
Message was sent while issue was closed.
Change committed as 276622

Powered by Google App Engine
This is Rietveld 408576698