Chromium Code Reviews| Index: Source/core/inspector/InspectorDOMAgent.cpp |
| diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp |
| index 87d30e359bafcbc834962e75fba1f3ff2468a45c..ae961b22ecf649be915f37fe17d094910d592c86 100644 |
| --- a/Source/core/inspector/InspectorDOMAgent.cpp |
| +++ b/Source/core/inspector/InspectorDOMAgent.cpp |
| @@ -180,18 +180,19 @@ static Node* hoveredNodeForEvent(LocalFrame* frame, const PlatformTouchEvent& ev |
| return hoveredNodeForPoint(frame, roundedIntPoint(points[0].pos()), ignorePointerEventsNone); |
| } |
| -class RevalidateStyleAttributeTask { |
| - WTF_MAKE_FAST_ALLOCATED; |
| +class RevalidateStyleAttributeTask : public NoBaseWillBeGarbageCollectedFinalized<RevalidateStyleAttributeTask> { |
| + WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED; |
| public: |
| RevalidateStyleAttributeTask(InspectorDOMAgent*); |
|
haraken
2014/06/19 05:49:53
Add explicit.
keishi
2014/07/24 02:15:02
Done.
|
| void scheduleFor(Element*); |
| void reset() { m_timer.stop(); } |
| void onTimer(Timer<RevalidateStyleAttributeTask>*); |
| + void trace(Visitor*); |
| private: |
| - InspectorDOMAgent* m_domAgent; |
| + RawPtrWillBeMember<InspectorDOMAgent> m_domAgent; |
| Timer<RevalidateStyleAttributeTask> m_timer; |
| - WillBePersistentHeapHashSet<RefPtrWillBeMember<Element> > m_elements; |
| + WillBeHeapHashSet<RefPtrWillBeMember<Element> > m_elements; |
| }; |
| RevalidateStyleAttributeTask::RevalidateStyleAttributeTask(InspectorDOMAgent* domAgent) |
| @@ -218,6 +219,12 @@ void RevalidateStyleAttributeTask::onTimer(Timer<RevalidateStyleAttributeTask>*) |
| m_elements.clear(); |
| } |
| +void RevalidateStyleAttributeTask::trace(Visitor* visitor) |
| +{ |
| + visitor->trace(m_domAgent); |
| + visitor->trace(m_elements); |
| +} |
| + |
| String InspectorDOMAgent::toErrorString(ExceptionState& exceptionState) |
| { |
| if (exceptionState.hadException()) |
| @@ -641,8 +648,7 @@ int InspectorDOMAgent::pushNodePathToFrontend(Node* nodeToPush) |
| if (!m_document) |
| return 0; |
| - // FIXME: Oilpan: .get will be unnecessary if m_document is a Member<>. |
| - if (!m_documentNodeToIdMap->contains(m_document.get())) |
| + if (!m_documentNodeToIdMap->contains(m_document)) |
| return 0; |
| // Return id in case the node is known. |
| @@ -1916,7 +1922,7 @@ void InspectorDOMAgent::didInvalidateStyleAttr(Node* node) |
| return; |
| if (!m_revalidateStyleAttrTask) |
| - m_revalidateStyleAttrTask = adoptPtr(new RevalidateStyleAttributeTask(this)); |
| + m_revalidateStyleAttrTask = adoptPtrWillBeNoop(new RevalidateStyleAttributeTask(this)); |
| m_revalidateStyleAttrTask->scheduleFor(toElement(node)); |
| } |
| @@ -2096,8 +2102,7 @@ PassRefPtr<TypeBuilder::Runtime::RemoteObject> InspectorDOMAgent::resolveNode(No |
| bool InspectorDOMAgent::pushDocumentUponHandlelessOperation(ErrorString* errorString) |
| { |
| - // FIXME: Oilpan: .get will be unnecessary if m_document is a Member<>. |
| - if (!m_documentNodeToIdMap->contains(m_document.get())) { |
| + if (!m_documentNodeToIdMap->contains(m_document)) { |
| RefPtr<TypeBuilder::DOM::Node> root; |
| getDocument(errorString, root); |
| return errorString->isEmpty(); |
| @@ -2109,6 +2114,7 @@ void InspectorDOMAgent::trace(Visitor* visitor) |
| { |
| visitor->trace(m_domListener); |
| visitor->trace(m_pageAgent); |
| + visitor->trace(m_injectedScriptManager); |
| #if ENABLE(OILPAN) |
| visitor->trace(m_documentNodeToIdMap); |
| visitor->trace(m_danglingNodeToIdMaps); |
| @@ -2116,6 +2122,7 @@ void InspectorDOMAgent::trace(Visitor* visitor) |
| #endif |
| visitor->trace(m_idToNodesMap); |
| visitor->trace(m_document); |
| + visitor->trace(m_revalidateStyleAttrTask); |
| visitor->trace(m_searchResults); |
| visitor->trace(m_history); |
| visitor->trace(m_domEditor); |