aura: Supports text input on non UTF-8 environments.

ui/events/keycodes/keyboard_code_conversion_x.cc

Index: ui/events/keycodes/keyboard_code_conversion_x.cc
diff --git a/ui/events/keycodes/keyboard_code_conversion_x.cc b/ui/events/keycodes/keyboard_code_conversion_x.cc
index 8e420ab29193b7c769b2e4b703522db0d48c6302..5d6c6ace60609550e06a34e47da506a94bef181b 100644
--- a/ui/events/keycodes/keyboard_code_conversion_x.cc
+++ b/ui/events/keycodes/keyboard_code_conversion_x.cc
@@ -13,6 +13,7 @@
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
+#include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/events/keycodes/dom4/keycode_converter.h"
 
@@ -436,9 +437,11 @@ uint16 GetCharacterFromXEvent(XEvent* xev) {
   int bytes_written = XLookupString(&xev->xkey, buf, 6, NULL, NULL);
   DCHECK_LE(bytes_written, 6);
 
-  base::string16 result;
-  return (bytes_written > 0 && base::UTF8ToUTF16(buf, bytes_written, &result) &&
-          result.length() == 1) ? result[0] : 0;
+  if (bytes_written <= 0)
+    return 0;
+  const base::string16& result = base::WideToUTF16(
+      base::SysNativeMBToWide(base::StringPiece(buf, bytes_written)));
+  return result.length() == 1 ? result[0] : 0;

[Wez, 2014/06/12 19:03:57]

What about characters outside the Basic Multilingual (i.e. 16-bit) Plane?

[Yuki, 2014/06/13 02:58:31]

It's simply not supported by this function.  Since this function returns uint16,
we cannot return such characters out of 16-bit.  Also the callers do not expect
it.  For example,
    text[i] = GetCharacterFromXEvent(native_event);
doesn't expect such characters.

Since this function is used for key events and AFAIK there is no such key, so it
should be okay at least for now.

If there were such keyboard, the resulting character code would be zero, and
users cannot type it.

If we really care such cases (I'm not really sure if there were the cases), we'd
better revisit that point later.

Can I go with this code for now?  At least this should be good as same as the
old implementation (the old code doesn't care about characters out of 16-bit,
too).

 }
 
 unsigned int DefaultXKeysymFromHardwareKeycode(unsigned int hardware_code) {