Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 323013005: Support for larger than "signed 32b limit" sized bitmaps in BGRAConvolve2D. (Closed)

Created:
6 years, 6 months ago by sugoi1
Modified:
6 years, 6 months ago
Reviewers:
rmistry, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Support for larger than "signed 32b limit" sized bitmaps in BGRAConvolve2D. The multiplication of 2 signed ints was producing a result larger than what's supported by a single signed int and the memory was accessed out of bounds. Using uint64_t solves the issue. BUG=378491 Committed: https://skia.googlesource.com/skia/+/35fcd15d0598bca6a265100ace5d10a0d992cf9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/core/SkConvolver.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sugoi1
6 years, 6 months ago (2014-06-10 20:42:14 UTC) #1
reed1
lgtm Lets create some tests (after this CL) that stress this more, so we can ...
6 years, 6 months ago (2014-06-10 21:33:39 UTC) #2
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 6 months ago (2014-06-11 12:01:05 UTC) #3
sugoi1
The CQ bit was unchecked by sugoi@chromium.org
6 years, 6 months ago (2014-06-11 12:01:09 UTC) #4
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 6 months ago (2014-06-11 12:27:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/323013005/1
6 years, 6 months ago (2014-06-11 12:28:37 UTC) #6
reed1
I like the change, but lets *definitely* write a unittest that crashes on the old ...
6 years, 6 months ago (2014-06-11 12:32:03 UTC) #7
rmistry
The CQ bit was unchecked by rmistry@google.com
6 years, 6 months ago (2014-06-11 13:16:43 UTC) #8
rmistry
I had restarted Skia's CQ which changed some trybots, it appears this CL was stuck ...
6 years, 6 months ago (2014-06-11 13:17:21 UTC) #9
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-11 13:17:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/323013005/1
6 years, 6 months ago (2014-06-11 13:17:58 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 13:31:32 UTC) #12
Message was sent while issue was closed.
Change committed as 35fcd15d0598bca6a265100ace5d10a0d992cf9c

Powered by Google App Engine
This is Rietveld 408576698