Add histograms to track age of cache entries for web fonts

net/disk_cache/blockfile/webfonts_histogram.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/blockfile/webfonts_histogram.h"
 
 #include "base/strings/string_piece.h"
 #include "base/strings/stringprintf.h"
 #include "net/disk_cache/blockfile/entry_impl.h"
 #include "net/disk_cache/blockfile/histogram_macros.h"
@@ skipping 60 matching lines @@
     RecordCacheEvent(CACHE_EVENT_MISS, label);
 }
 
 void RecordEvictedEntry(const std::string& key) {
   const char* label = HistogramLabel(key);
   if (label)
     RecordCacheEvent(CACHE_EVENT_EVICTED_ENTRY, label);
 }
 
 void RecordCacheHit(EntryImpl* entry) {
-  const char* label = HistogramLabel(entry->entry()->Data()->key);
+  EntryStore* info = entry->entry()->Data();
+  const char* label = HistogramLabel(info->key);

[rvargas (doing something else), 2014/06/10 23:15:33]

I just realized that this is wrong. This should not be accessing the key field
directly, it should be calling entry->GetKey()

[Kunihiko Sakamoto, 2014/06/11 01:50:10]

Done.

   if (!label)
     return;
   CACHE_HISTOGRAM_COUNTS_10000(HistogramName("DiskCache.ReuseCount.Hit", label),
-                               entry->entry()->Data()->reuse_count);
+                               info->reuse_count);
+  CACHE_HISTOGRAM_AGE(HistogramName("DiskCache.EntryAge.Hit", label),
+                      base::Time::FromInternalValue(info->creation_time));
   RecordCacheEvent(CACHE_EVENT_HIT, label);
 }
 
 void RecordEviction(EntryImpl* entry) {
-  const char* label = HistogramLabel(entry->entry()->Data()->key);
-  if (label)
+  EntryStore* info = entry->entry()->Data();
+  const char* label = HistogramLabel(info->key);
+  if (!label)
     return;
   CACHE_HISTOGRAM_COUNTS_10000(
       HistogramName("DiskCache.ReuseCount.Evict", label),
-      entry->entry()->Data()->reuse_count);
+      info->reuse_count);
+  CACHE_HISTOGRAM_AGE(HistogramName("DiskCache.EntryAge.Evict", label),
+                      base::Time::FromInternalValue(info->creation_time));
 }
 
 }  // namespace web_fonts_histogram
 }  // namespace disk_cache