Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 323003007: Revert of Removing WTL from content runner. (Closed)

Created:
6 years, 6 months ago by alph
Modified:
6 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert of Removing WTL from content runner. (https://codereview.chromium.org/323723002/) Reason for revert: Speculative revert for breaking TestAccessibleHWND unit test. http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/14186 Original issue's description: > Removing WTL from content runner. > > The _Module object is used by ATL COM classes to lock the module, like so > > _pAtlModule->Lock(); > > For example when CreateInstance is called: > > BrowserAccessibility* BrowserAccessibility::Create() { > CComObject<BrowserAccessibilityWin>* instance; > HRESULT hr = CComObject<BrowserAccessibilityWin>::CreateInstance(&instance); > > We need to get rid of WTL so we can get rid of ATL since it > causes many problems. See bug for details. > > BUG=5027 > TEST=chrome runs. Accessibility works. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275987 TBR=jam@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=5027 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/app/content_main_runner.cc View 4 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alph
Created Revert of Removing WTL from content runner.
6 years, 6 months ago (2014-06-10 16:00:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/323003007/1
6 years, 6 months ago (2014-06-10 16:03:41 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 16:06:22 UTC) #3
Message was sent while issue was closed.
Change committed as 276046

Powered by Google App Engine
This is Rietveld 408576698