Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 322983002: Add GN Build file for ui/events/ozone. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, rjkroege, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org, scottmg, ajwong, Dirk Pranke
Visibility:
Public.

Description

Add GN Build file for ui/events/ozone. This was tested with: $ gn gen out/Debug_gn --args='use_ozone=true' $ ninja -C out/Debug_gn events_ozone events_ozone_evdev BUG=None TEST=see above R=brettw@chromium.org TBR=ben@chromium # for ui/ changes NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276044

Patch Set 1 #

Total comments: 3

Patch Set 2 : sort #

Total comments: 4

Patch Set 3 : brett fixes #

Total comments: 2

Patch Set 4 : on top #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -17 lines) Patch
M BUILD.gn View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M build/config/linux/BUILD.gn View 2 chunks +11 lines, -0 lines 0 comments Download
M build/config/ui.gni View 2 chunks +5 lines, -0 lines 0 comments Download
A device/udev_linux/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A ui/events/ozone/BUILD.gn View 1 2 3 1 chunk +101 lines, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Certainly not the easiest. But it was fun to do. https://codereview.chromium.org/322983002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/322983002/diff/1/BUILD.gn#newcode21 ...
6 years, 6 months ago (2014-06-10 03:42:54 UTC) #1
brettw
Thanks for looking at this one! https://codereview.chromium.org/322983002/diff/20001/ui/events/ozone/BUILD.gn File ui/events/ozone/BUILD.gn (right): https://codereview.chromium.org/322983002/diff/20001/ui/events/ozone/BUILD.gn#newcode33 ui/events/ozone/BUILD.gn:33: sources_assignment_filter += [ ...
6 years, 6 months ago (2014-06-10 05:13:19 UTC) #2
tfarina
https://codereview.chromium.org/322983002/diff/20001/ui/events/ozone/BUILD.gn File ui/events/ozone/BUILD.gn (right): https://codereview.chromium.org/322983002/diff/20001/ui/events/ozone/BUILD.gn#newcode33 ui/events/ozone/BUILD.gn:33: sources_assignment_filter += [ On 2014/06/10 05:13:18, brettw wrote: > ...
6 years, 6 months ago (2014-06-10 05:24:37 UTC) #3
brettw
LGTM! https://codereview.chromium.org/322983002/diff/40001/ui/events/ozone/BUILD.gn File ui/events/ozone/BUILD.gn (right): https://codereview.chromium.org/322983002/diff/40001/ui/events/ozone/BUILD.gn#newcode71 ui/events/ozone/BUILD.gn:71: ":events_ozone", This goes at the top of the ...
6 years, 6 months ago (2014-06-10 05:45:29 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-10 15:44:41 UTC) #5
tfarina
https://codereview.chromium.org/322983002/diff/40001/ui/events/ozone/BUILD.gn File ui/events/ozone/BUILD.gn (right): https://codereview.chromium.org/322983002/diff/40001/ui/events/ozone/BUILD.gn#newcode71 ui/events/ozone/BUILD.gn:71: ":events_ozone", On 2014/06/10 05:45:29, brettw wrote: > This goes ...
6 years, 6 months ago (2014-06-10 15:44:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/322983002/60001
6 years, 6 months ago (2014-06-10 15:49:56 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 15:58:49 UTC) #8
Message was sent while issue was closed.
Change committed as 276044

Powered by Google App Engine
This is Rietveld 408576698