Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
322973005:
Dismiss IME on renderer process change (Closed)
|
Created:
6 years, 6 months ago by raghu Modified:
6 years, 6 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, use-l.gombos-samsung.com, Inactive Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionDismiss IME on renderer process change
If the Ime is already showing when the renderer process changes,
it stays open and cannot be used.
Now hiding the Ime when render process is changed
ImeAdapter attach gets called through attachImeAdapter in ContentViewCore onRenderProcessChange
BUG=382863
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277737
Patch Set 1 #Patch Set 2 : Adding my name to the Authors #Patch Set 3 : Discaring adding my name to AUTOHRS as it is already done #Patch Set 4 : Dismiss IME on renderer process change #Messages
Total messages: 30 (0 generated)
PTAL
lgtm
lgtm
The CQ bit was checked by r.ghatage@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by r.ghatage@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by r.ghatage@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by r.ghatage@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
The CQ bit was unchecked by r.ghatage@samsung.com
The CQ bit was checked by r.ghatage@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/40001
The CQ bit was unchecked by r.ghatage@samsung.com
The CQ bit was checked by r.ghatage@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/60001
Message was sent while issue was closed.
Change committed as 277737 |
