Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 322973005: Dismiss IME on renderer process change (Closed)

Created:
6 years, 6 months ago by raghu
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, use-l.gombos-samsung.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Dismiss IME on renderer process change If the Ime is already showing when the renderer process changes, it stays open and cannot be used. Now hiding the Ime when render process is changed ImeAdapter attach gets called through attachImeAdapter in ContentViewCore onRenderProcessChange BUG=382863 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277737

Patch Set 1 #

Patch Set 2 : Adding my name to the Authors #

Patch Set 3 : Discaring adding my name to AUTOHRS as it is already done #

Patch Set 4 : Dismiss IME on renderer process change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 2 3 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
raghu
PTAL
6 years, 6 months ago (2014-06-10 10:08:28 UTC) #1
aurimas (slooooooooow)
lgtm
6 years, 6 months ago (2014-06-10 20:53:32 UTC) #2
cjhopman
lgtm
6 years, 6 months ago (2014-06-12 17:42:55 UTC) #3
raghu
The CQ bit was checked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-13 07:06:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
6 years, 6 months ago (2014-06-13 07:08:31 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 11:02:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 12:19:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/162283)
6 years, 6 months ago (2014-06-13 12:19:15 UTC) #8
raghu
The CQ bit was checked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-13 13:54:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
6 years, 6 months ago (2014-06-13 13:55:18 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 20:45:30 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 21:07:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/162460)
6 years, 6 months ago (2014-06-13 21:07:46 UTC) #13
raghu
The CQ bit was checked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-14 01:30:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
6 years, 6 months ago (2014-06-14 01:32:05 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-14 04:05:49 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/162602)
6 years, 6 months ago (2014-06-14 04:05:50 UTC) #17
raghu
The CQ bit was checked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-16 09:34:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
6 years, 6 months ago (2014-06-16 09:35:36 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 12:13:16 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/162769)
6 years, 6 months ago (2014-06-16 12:13:17 UTC) #21
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 6 months ago (2014-06-16 15:41:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/20001
6 years, 6 months ago (2014-06-16 15:44:05 UTC) #23
raghu
The CQ bit was unchecked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-16 17:56:36 UTC) #24
raghu
The CQ bit was checked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-17 06:09:35 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/40001
6 years, 6 months ago (2014-06-17 06:10:42 UTC) #26
raghu
The CQ bit was unchecked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-17 07:25:33 UTC) #27
raghu
The CQ bit was checked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-17 08:41:28 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/322973005/60001
6 years, 6 months ago (2014-06-17 08:43:38 UTC) #29
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 12:12:12 UTC) #30
Message was sent while issue was closed.
Change committed as 277737

Powered by Google App Engine
This is Rietveld 408576698