tools/skdiff_utils.cpp - Issue 322963002: hide SkBitmap::setConfig

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skdiff_utils.cpp

Issue 322963002: hide SkBitmap::setConfig (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skdiff_utils.cpp

diff --git a/tools/skdiff_utils.cpp b/tools/skdiff_utils.cpp

index 5ca3d8085d054592146cdc35b2ffed5cc4d02d5f..5c9aae275aab23dd7755f6490e774522ac0bb3c6 100644

--- a/tools/skdiff_utils.cpp

+++ b/tools/skdiff_utils.cpp

@@ -144,11 +144,9 @@ void create_and_write_diff_image(DiffRecord* drp,

if (w != drp->fComparison.fBitmap.width() || h != drp->fComparison.fBitmap.height()) {

drp->fResult = DiffRecord::kDifferentSizes_Result;

} else {

- drp->fDifference.fBitmap.setConfig(SkBitmap::kARGB_8888_Config, w, h);

- drp->fDifference.fBitmap.allocPixels();

+ drp->fDifference.fBitmap.allocN32Pixels(w, h);

- drp->fWhite.fBitmap.setConfig(SkBitmap::kARGB_8888_Config, w, h);

- drp->fWhite.fBitmap.allocPixels();

+ drp->fWhite.fBitmap.allocN32Pixels(w, h);

SkASSERT(DiffRecord::kUnknown_Result == drp->fResult);

compute_diff(drp, dmp, colorThreshold);

« no previous file with comments | « tools/picture_utils.cpp ('k') | tools/skpdiff/SkDifferentPixelsMetric_cpu.cpp » ('j') | no next file with comments »