experimental/PdfViewer/pdf_viewer_main.cpp - Issue 322963002: hide SkBitmap::setConfig

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/pdf_viewer_main.cpp

Issue 322963002: hide SkBitmap::setConfig (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: experimental/PdfViewer/pdf_viewer_main.cpp

diff --git a/experimental/PdfViewer/pdf_viewer_main.cpp b/experimental/PdfViewer/pdf_viewer_main.cpp

index 6395585c4d0a96a084ba86a1267923851546879a..2f1a055e4d63c0c798cd84e08e3c8f3deeaed444 100644

--- a/experimental/PdfViewer/pdf_viewer_main.cpp

+++ b/experimental/PdfViewer/pdf_viewer_main.cpp

@@ -110,9 +110,7 @@ static bool make_output_filepath(SkString* path, const SkString& dir,

}

static void setup_bitmap(SkBitmap* bitmap, int width, int height, SkColor color) {

- bitmap->setConfig(SkBitmap::kARGB_8888_Config, width, height);

- bitmap->allocPixels();

+ bitmap->allocN32Pixels(width, height);

bitmap->eraseColor(color);

}